Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] base_exception: Migration to 17.0 #2809

Merged
merged 66 commits into from
Feb 2, 2024
Merged

[17.0][MIG] base_exception: Migration to 17.0 #2809

merged 66 commits into from
Feb 2, 2024

Conversation

lef-adhoc
Copy link

No description provided.

mourad-ehm and others added 30 commits January 16, 2024 18:08
@mourad-ehm @lef-adhoc
[ADD] split module sale_exception into base_exception
05d595d
@lmignon @lef-adhoc
[FIX] base_exception: '_check_exception' is 'api.multi' since it's ca…
4e96d7d 
…lled by constraint methods

'detect_exception' can be called on an empty recordset.
@mourad-ehm @lef-adhoc
[MIG] base_exception: Migration to 11.0
467f8dd
@mourad-ehm @lef-adhoc
[FIX] temp model test access rule & fix OCA remarks
8916185
@astirpe @lef-adhoc
[FIX] Enable post_install for tests + pylint
be577fc
@ivantodorovich @lef-adhoc
[IMP] Update base_exception views
cd57eb7 
- Show menu only to Exception Rule Managers
- Use sequence and active widgets on tree view
- Updated form to use sheet
@bealdav @lef-adhoc
FIX remove old api parameters in base_exception
838339d
@nicomacr @lef-adhoc
[FIX] base_exception: send the active_model in the conxtext when call…
416f440 
… the _popup_exceptions mehtod
@ivantodorovich @lef-adhoc
[MIG] base_exception: Migration to 12.0
ad193b7
@mourad-ehm @lef-adhoc
[WIP] sale_exception_by_domain
5e8b92b
@ivantodorovich @lef-adhoc
FIX self[0] in _rule_group
335b422
@ivantodorovich @lef-adhoc
[MIG] dict.iteritems() does not exist in Python3
c5c8640
@lef-adhoc
[IMP] Add convenience action to ignore exceptions on record
e35b730 
[IMP] Computed exception descriptions field, to display better help messages

[IMP] Exceptions shouldn't be copied
@jaredkipe @lef-adhoc
[IMP] base_exception: black, isort
8bb03e4
@jaredkipe @lef-adhoc
[MIG] base_exception: Migration to 13.0
7d48027
@oca-travis @lef-adhoc
[UPD] Update base_exception.pot
bdea76c
@kevinkhao @lef-adhoc
[IMP] base_exception: black, isort, prettify
ca28712
@kevinkhao @lef-adhoc
[14.0][MIG] base_exception: Migration to 14.0
d68b825
@OCA-git-bot @lef-adhoc
[UPD] README.rst
a148c63
@sebastienbeau @lef-adhoc
[FIX] fix access right
7c61d47
@MiquelRForgeFlow @lef-adhoc
[FIX] base_exception: import correctly osv.expression
0a39655
@kittiu @lef-adhoc
[14.0][FIX] base_exception, error if rule's description is null
9170475
@oca-travis @lef-adhoc
[UPD] Update base_exception.pot
823ac5a
@ivantodorovich @lef-adhoc
[IMP] base_exception: Allow to skip exception checks through context
3783a95
@JordiBForgeFlow @lef-adhoc
[13.0][fix][base_exception] search only active exception rules
0554460
@TDu @lef-adhoc
[13.0][IMP] base_exception add blocking exceptions
6994ba4 
By default exceptions can be ignored by the click of a button.
Users begin human they will just click that button what ever
the internal rules.

So this PR adds the option to set specific exceptions as blocking.

When exceptions are detected if one of them is blocking, the user
will not be able to ignore them.
@hailangvn @lef-adhoc
[IMP] base_exception: test blocking exceptions
8fc680c
@sebastienbeau @lef-adhoc
[IMP] add method exception
91fb471
@sebastienbeau @lef-adhoc
[REF] Refactor test
e41b48f 
use odoo-test-helper
split test so one test do one thing
@ivantodorovich @lef-adhoc
[IMP] base_exception: log traceback when code exception is raised
9c26945
@lef-adhoc lef-adhoc force-pushed the 17.0-mig-base_exception branch 5 times, most recently from 72d66c0 to 44d0e32 Compare January 17, 2024 13:30
@lef-adhoc lef-adhoc mentioned this pull request Jan 17, 2024
Closed
@lef-adhoc lef-adhoc mentioned this pull request Jan 18, 2024
Closed
2 tasks
nguyenminhchien
nguyenminhchien suggested changes Jan 19, 2024
View reviewed changes
base_exception/wizard/base_exception_confirm_view.xml Outdated
<footer>
<button
name="action_confirm"
string="_Close"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "_Close" is a typo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready

base_exception/views/base_exception_view.xml Outdated
string="Help"
invisible="exception_type != 'by_py_code'"
>
<group>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the view is broken, we should remove the <group>
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready

@lef-adhoc lef-adhoc force-pushed the 17.0-mig-base_exception branch from 44d0e32 to 7d0237f Compare January 25, 2024 20:08
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

2 similar comments
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@john-herholz-dt
Copy link

@sebastienbeau , Can you merge this? I have several PRs depending on this. Thank you!

@gurneyalex
Copy link
Member

/ocabot migration base_exception

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 2, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#2752) has not been updated to reference the current pull request because a previous pull request (#2761) is not closed.
Perhaps you should check that there is no duplicate work.
CC @peluko00

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2809-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c5fcea1 into OCA:17.0 Feb 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3d1b0d9. Thanks a lot for contributing to OCA. ❤️

This was referenced Feb 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasperalta1 matiasperalta1 matiasperalta1 approved these changes

@nguyenminhchien nguyenminhchien nguyenminhchien approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.