[16.0][ADD] attachment_log #3161

geomer198 · 2025-01-09T17:48:17Z

This module adds the following features for attachments:

Displays the date and time when each attachment was added under the attachment file
Records chatter messages showing which user linked or unlinked files to attachments

hoangtrann · 2025-01-11T09:04:08Z

attachment_log/models/ir_attachment.py

+        message = record.message_post(
+            body=Markup(
+                _(
+                    "User <b>%(username)s</b> is attached a new file: <i>%(filename)s</i>"


Suggested change

"User %(username)s is attached a new file: %(filename)s"

"%(username)s attached a file: %(filename)s"

It would then show as Mitchell Admin attached a file: Invoice.pdf

ivs-cetmix

Here are my concerns: why should we post a message for every attachment added?
What if an incoming email arrives with 10+ attachments in it? It will result in 10+ messages trashing the record chatter.
You can simply show name of the user who added attachment together with the creation date. That is.

ivs-cetmix · 2025-01-11T19:20:50Z

attachment_log/__manifest__.py

+    "website": "https://github.com/OCA/server-tools",
+    "license": "AGPL-3",
+    "category": "Generic Modules",
+    "depends": ["base", "mail"],


You don't need to depend on base because mail already depends on it.

ivs-cetmix

You should add test coverage for the features you are adding.

ivs-cetmix · 2025-01-14T19:56:18Z

attachment_log/models/ir_attachment.py

+        record = self.env[self.res_model].sudo().browse(self.res_id)
+        message_text = _(
+            "<b>%(username)s</b> %(action)s a file: <i>%(filename)s</i>"
+        ) % {


Please use correct method for string translations.

ivs-cetmix · 2025-01-14T19:58:24Z

attachment_log/__manifest__.py

+    "summary": "Add log info for attachments",
+    "website": "https://github.com/OCA/server-tools",
+    "license": "AGPL-3",
+    "category": "Generic Modules",


Are you sure that such category exists? If yes, please share a link to it.

ivs-cetmix · 2025-01-14T19:58:59Z

attachment_log/__manifest__.py

+            "attachment_log/static/src/components/*/*",
+        ]
+    },
+    "installable": True,


True is the default value for this key, no need to add it.

ivs-cetmix · 2025-01-14T20:01:57Z

attachment_log/models/ir_attachment.py

+class IrAttachment(models.Model):
+    _inherit = "ir.attachment"
+
+    def _send_attachment_notification(self, is_create=False, is_unlink=False):


Posting messages in chatter should be an option that is toggled in the configuration. Because some users might considered it not useful and even annoying.

ivs-cetmix · 2025-01-14T20:04:01Z

attachment_log/__manifest__.py

@@ -0,0 +1,18 @@
+{
+    "name": "Attachment Log",


Name is irrelevant because you are not adding any logging. There is no attachment log implemented.
It either logging or tracking.
Suggested name could be "Attachment Logging" with the technical name adjusted accordingly.

ivs-cetmix · 2025-01-14T20:06:13Z

attachment_log/__manifest__.py

+    "name": "Attachment Log",
+    "version": "16.0.1.0.0",
+    "author": "Cetmix, Odoo Community Association (OCA)",
+    "summary": "Add log info for attachments",


You are not adding any log info to attachments. You are showing tracking information or metadata.
So should be something like Show attachment information in chatter.

ivs-cetmix · 2025-01-14T20:10:33Z

attachment_log/readme/DESCRIPTION.rst

@@ -0,0 +1,4 @@
+This module adds the following features for attachments:


This module shows attachment information in chatter. Following data is displayed:

User, who has created the attachment

Attachment creation date

It also allows to log attachment related actions in the record chatter.

ivs-cetmix · 2025-01-14T20:12:18Z

attachment_log/models/ir_attachment.py

+            "filename": self.name,
+            "action": action,
+        }
+        message = record.message_post(


You should use a custom message subtype for such messages in order to allow more flexible configuration.

ivs-cetmix

You need to add CONFIGURE.rts to explain the configuration process.

To enable note logging of attachment operations in record chatter: 

- Go to "Settings > General Settings" and scroll to the "Discuss" section.
- Activate the "Attachment Logging" checkbox.

Add screenshots that make both configuration and usage easier. Must be not more than 800px width.
Here is an example. Don't use this picture because you need to fix the configuration view first.

ivs-cetmix · 2025-01-16T10:27:34Z

attachment_logging/__manifest__.py

+    "name": "Attachment Logging",
+    "version": "16.0.1.0.0",
+    "author": "Cetmix, Odoo Community Association (OCA)",
+    "summary": "Show attachment  information in chatter",


Show attachment<remove_extra_space_here> information in chatter

ivs-cetmix · 2025-01-16T10:31:08Z

attachment_logging/models/res_config_settings.py

+
+    use_attachment_log = fields.Boolean(
+        config_parameter="attachment_logging.use_attachment_log",
+        help="Log a file operation for record in chatter",


Log attachment operations in chatter

ivs-cetmix · 2025-01-16T10:36:08Z

attachment_logging/readme/USAGE.rst

@@ -0,0 +1 @@
+Module automatically log in chatter  the date and time when each attachment was added and which user linked or unlinked files to attachments.


Create date and user are displayed next to attachments in chatter.
When attachment is added or removed a note is logged in chatter if the corresponding option is enabled in the General Settings.

ivs-cetmix · 2025-01-16T10:38:45Z

attachment_logging/views/res_config_settings_views.xml

+                        <field name="use_attachment_log" />
+                    </div>
+                    <div class="o_setting_right_pane">
+                        <span class="o_form_label">Attachment Log</span>


Attachment Logging

ivs-cetmix · 2025-01-16T10:38:50Z

attachment_logging/views/res_config_settings_views.xml

+                    <div class="o_setting_right_pane">
+                        <span class="o_form_label">Attachment Log</span>
+                        <div class="text-muted col-md-12">
+                            Log attached or unlinked file in chatter


Log a note in record chatter when an attachment is added or removed.

ivs-cetmix · 2025-01-16T10:39:52Z

attachment_logging/views/res_config_settings_views.xml

+                        <div class="text-muted col-md-12">
+                            Log attached or unlinked file in chatter
+                        </div>
+                        <div


What is this twillio div doing here?

ivs-cetmix

Code review LGTM

yostashiro · 2025-01-19T23:39:17Z

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

ivs-cetmix · 2025-01-21T10:00:41Z

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

Hi @yostashiro! Thank you for noticing that! Will fix.

…s fixed

[ADD] attachment_log: Module added

fc0cd0a

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from 9b18974 to fc0cd0a Compare January 9, 2025 17:48

hoangtrann suggested changes Jan 11, 2025

View reviewed changes

[FIX] attachment_log: Log message is updated

3108f5e

ivs-cetmix suggested changes Jan 11, 2025

View reviewed changes

[FIX] attachment_log: Code review fixing

4d4a398

ivs-cetmix suggested changes Jan 14, 2025

View reviewed changes

geomer198 added 2 commits January 15, 2025 22:17

[FIX] attachment_logging: Module refactoring

3abf18a

[IMP] attachment_logging: Tests are added

e9e2678

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from cd55848 to 7e55b4c Compare January 15, 2025 21:44

[FIX] attachment_logging: Test are updated

81f090d

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from 7e55b4c to 81f090d Compare January 15, 2025 21:44

ivs-cetmix suggested changes Jan 16, 2025

View reviewed changes

[FIX] attachment_logging: Code review fixing

bc7ee8d

ivs-cetmix approved these changes Jan 19, 2025

View reviewed changes

[FIX] attachment_logging: attache file to model without mail.thread i…

f2c61f7

…s fixed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] attachment_log #3161

[16.0][ADD] attachment_log #3161

geomer198 commented Jan 9, 2025

hoangtrann Jan 11, 2025

hoangtrann Jan 11, 2025

ivs-cetmix left a comment

ivs-cetmix Jan 11, 2025

ivs-cetmix left a comment

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix Jan 14, 2025

ivs-cetmix left a comment

ivs-cetmix Jan 16, 2025

ivs-cetmix Jan 16, 2025

ivs-cetmix Jan 16, 2025

ivs-cetmix Jan 16, 2025

ivs-cetmix Jan 16, 2025

ivs-cetmix Jan 16, 2025

ivs-cetmix left a comment

yostashiro commented Jan 19, 2025 •

edited

Loading

ivs-cetmix commented Jan 21, 2025

	"User <b>%(username)s</b> is attached a new file: <i>%(filename)s</i>"
	"<b>%(username)s</b> attached a file: <i>%(filename)s</i>"

		@@ -0,0 +1,4 @@
		This module adds the following features for attachments:

		@@ -0,0 +1 @@
		Module automatically log in chatter the date and time when each attachment was added and which user linked or unlinked files to attachments.

[16.0][ADD] attachment_log #3161

Are you sure you want to change the base?

[16.0][ADD] attachment_log #3161

Conversation

geomer198 commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

yostashiro commented Jan 19, 2025 • edited Loading

ivs-cetmix commented Jan 21, 2025

yostashiro commented Jan 19, 2025 •

edited

Loading