[18.0][MIG] sequence_check_digit: Migration to 18.0

[yankinmax]

No description provided.

[StephaneMangin]

I wonder if adding a log for missing and mandatory dependencies makes sense. Despite the fact that it fails the codecov plugin.

+ import logging
+ 
+ from odoo.exceptions import ValidationError
+ from odoo.tests import common
+ 
+ _logger = logging.getLogger(__name__)
+ try:
+     from stdnum import damm, luhn, verhoeff
+     from stdnum.iso7064 import mod_11_2, mod_11_10, mod_37_2, mod_37_36, mod_97_10
+ except (OSError, ImportError) as err:
+     _logger.debug(err)
+ 
+ 

[StephaneMangin]

A quick unitest to handle the codecov requirements could be to add such a method in the tests battery:

    def test_get_check_digit_exceptions(self):
        sequence = self.get_sequence("none")
        with self.assertRaises(ValidationError):
            sequence.get_check_digit("ABC")

[vvrossem]

LGTM.
please squash administrative commits to reduce commit noise 🙏

[yankinmax]

I wonder if adding a log for missing and mandatory dependencies makes sense. Despite the fact that it fails the codecov plugin.

+ import logging
+ 
+ from odoo.exceptions import ValidationError
+ from odoo.tests import common
+ 
+ _logger = logging.getLogger(__name__)
+ try:
+     from stdnum import damm, luhn, verhoeff
+     from stdnum.iso7064 import mod_11_2, mod_11_10, mod_37_2, mod_37_36, mod_97_10
+ except (OSError, ImportError) as err:
+     _logger.debug(err)
+ 
+ 

I've checked the other typical modules. In general, it's the same way to inform the admin of missing dependency

[yankinmax]

A quick unitest to handle the codecov requirements could be to add such a method in the tests battery:

    def test_get_check_digit_exceptions(self):
        sequence = self.get_sequence("none")
        with self.assertRaises(ValidationError):
            sequence.get_check_digit("ABC")

Added

[StephaneMangin]

LGTM