[14.0] [IMP] sale_input_barcode: scan directly on sale.order #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bealdav, |
SylweKra
force-pushed
the
14.0-FIX-sale_input_barcode
branch
2 times, most recently
from
a3fc16d to
02ddda4
Compare
aleuffre
suggested changes
Jan 22, 2025
sale_input_barcode/readme/USAGE.rst
Outdated
Comment on lines
13
to
14
| If a product is already inside the sale order lines, | ||
| the quantity will be updated. |
There was a problem hiding this comment.
chore: Update documentation
There was a problem hiding this comment.
I added the documentation.Let me know if it is clear and understandable.
Comment on lines
7
to
17
| <xpath expr="//div[@id='no_edit_order']" position="inside"> | ||
| <div class="o_setting_left_pane"> | ||
| <field name="sale_sol_creation_settings" /> | ||
| </div> | ||
| <div class="o_setting_right_pane"> | ||
| <label for="sale_sol_creation_settings" /> | ||
| <div class="text-muted"> | ||
| Instead of creating a new sale order line it increases the quantity for each barcode scan | ||
| </div> | ||
| </div> | ||
|
|
||
|
|
||
|
|
||
| </xpath> |
There was a problem hiding this comment.
chore: could you fix the formatting here, please?
There was a problem hiding this comment.
I have improved the formatting. Let me know.
|
|
||
| _inherit = "res.config.settings" | ||
|
|
||
| sale_sol_creation_settings = fields.Boolean( |
There was a problem hiding this comment.
nitpick(non-blocking): the name of this setting does not clearly reflect what the setting does IMO.
what about something like: sale_barcode_update_existing_line?
There was a problem hiding this comment.
ok, I've changed the name of the variable as you suggested.
SylweKra
force-pushed
the
14.0-FIX-sale_input_barcode
branch
2 times, most recently
from
1cf4e2b to
d1bef11
Compare
SylweKra
changed the title
SylweKra
changed the title
SylweKra
force-pushed
the
14.0-FIX-sale_input_barcode
branch
2 times, most recently
from
b416328 to
6a04e00
Compare
SylweKra
force-pushed
the
14.0-FIX-sale_input_barcode
branch
from
6a04e00 to
b546cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #611