Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] stock_quant_reservation_info: Migration to 17.0 #2206

Merged
merged 26 commits into from
Dec 9, 2024

Conversation

MeritxellAForgeFlow
Copy link

Migration to 17.0
@ForgeFlow

DavidJForgeFlow and others added 25 commits November 26, 2024 12:24
Currently translated at 100.0% (8 of 8 strings)

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_reservation_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_reservation_info/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_quant_reservation_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_quant_reservation_info/
Currently translated at 80.0% (4 of 5 strings)

Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_quant_reservation_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_quant_reservation_info/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_reservation_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_reservation_info/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_quant_reservation_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_quant_reservation_info/it/
Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! But there is a small detail for this version!

stock_quant_reservation_info/views/stock_quant.xml Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

/ocabot migration stock_quant_reservation_info

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 28, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 28, 2024
50 tasks
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@MeritxellAForgeFlow MeritxellAForgeFlow force-pushed the 17.0-mig-stock_quant_reservation_info branch from adc4cf1 to d77f88f Compare November 29, 2024 11:35
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

I miss the button to show reservation info

EDIT: this review was from the other PR #2208. In this one I see the button but I see the reserved qty 2 times:

image

@MeritxellAForgeFlow MeritxellAForgeFlow force-pushed the 17.0-mig-stock_quant_reservation_info branch from d77f88f to b6cc440 Compare December 5, 2024 10:32
@MeritxellAForgeFlow MeritxellAForgeFlow force-pushed the 17.0-mig-stock_quant_reservation_info branch from b6cc440 to 43df818 Compare December 5, 2024 12:03
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it LGTM!

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2206-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0475644 into OCA:17.0 Dec 9, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c7400b3. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 17.0-mig-stock_quant_reservation_info branch December 9, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.