Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_move_line_stock_info #2221

Merged
merged 38 commits into from
Dec 31, 2024

Conversation

JasminSForgeFlow
Copy link
Contributor

Standard Migration

@ForgeFlow

JordiBForgeFlow and others added 30 commits December 16, 2024 17:22
* [ADD] account_move_line_stock_info
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-account_move_line_stock_info/pt_BR/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-account_move_line_stock_info/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-account_move_line_stock_info/zh_CN/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-account_move_line_stock_info/ca/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/es/
Currently translated at 50.0% (2 of 4 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/it/
OCA-git-bot and others added 7 commits December 16, 2024 17:22
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/fr/
* Minor adjustments
* Attrs substitution
* Readme update
* Add the journal items to the simlified operations form view

Co-authored-by: stefan@opener.amsterdam
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-account_move_line_stock_info
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-account_move_line_stock_info/
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review 👍🏼

@@ -80,7 +80,6 @@ def _create_account(self, acc_type, name, code, company):
"name": name,
"code": code,
"account_type": acc_type,
"company_id": company.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use company_ids now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, Thanks

_inherit = "account.move.line"

stock_move_id = fields.Many2one(
comodel_name="stock.move", string="Stock Move", copy=False, index=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pplease use the same index as in https://github.com/odoo/odoo/tree/18.0/addons/stock_account/models#L10

Is this redefinition even needed?

Copy link
Contributor Author

@JasminSForgeFlow JasminSForgeFlow Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index updated,
and field is availble on account.move not on account.move.line

Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Sorry.

@JasminSForgeFlow JasminSForgeFlow force-pushed the 18.0-mig-account_move_line_stock_info branch from ed7214e to 27fc5df Compare December 17, 2024 04:26
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux
Copy link
Contributor

/ocabot migration account_move_line_stock_info

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 31, 2024
25 tasks
@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-2221-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 40d0542 into OCA:18.0 Dec 31, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8923fad. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-mig-account_move_line_stock_info branch December 31, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.