[14.0][IMP] stock_location_last_inventory_date: Make last_inventory_date storeable #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt-software-de
changed the title
mt-software-de
changed the title
mt-software-de
force-pushed
the
14-imp-stock_location_last_inventory_date
branch
from
f07a99c to
dbe1f5b
Compare
|
@hailangvn @sebalix @simahawk |
vuwnevska
reviewed
Dec 17, 2024
jbaudoux
requested changes
Dec 17, 2024
There was a problem hiding this comment.
You can make an inventory of a location without making any inventory line. I would have not changed that concept.
In newer versions, it's updating the date when the inventory is posted. You could go that way and make a migration script of the initialization of the field.
mt-software-de
force-pushed
the
14-imp-stock_location_last_inventory_date
branch
from
dbe1f5b to
dcdb125
Compare
vuwnevska
approved these changes
Dec 18, 2024
jbaudoux
reviewed
Dec 18, 2024
…oreable This allows to search this field
mt-software-de
force-pushed
the
14-imp-stock_location_last_inventory_date
branch
from
dcdb125 to
0e0121d
Compare
jbaudoux
approved these changes
Jan 8, 2025
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make this field searchable. At first i tried to create a search method for it, but it was not nice to implement, since the location of
stock.inventoryis used. Storing the date is easier. Therefor i changed the computation to usestock.inventory.lineinstead ofstock.inventory, because this record contains a direct link to a location.