Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465

Open
wants to merge 66 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465

wants to merge 66 commits into from

Conversation

AungKoKoLin1997
Copy link
Contributor

Standard Migration

@qrtl

@AaronHForgeFlow
Copy link
Contributor

The readme is quite short. How can I do a functional test on this module? creating a inventory adjustment on a past date? Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves?

@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Jan 4, 2024 •
edited
Loading

How can I do a functional test on this module? creating a inventory adjustment on a past date?

@AaronHForgeFlow I didn't test with inventory adjustment. For clear testing, I test with this module OCA/purchase-workflow#2137. So, we can adjust the price_unit of move from purchase order line.

Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves?

Yes, It does and also adjusts the cost of product.

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Jan 4, 2024
Merged
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review January 5, 2024 01:06
@rousseldenis
Copy link
Contributor

/ocabot migration product_cost_price_avco_sync

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 15, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 15, 2024
Open
70 tasks
rousseldenis
rousseldenis approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 22b0a0c to 52228bb Compare April 10, 2024 08:41
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 52228bb to 32f5cef Compare June 12, 2024 03:55
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch 2 times, most recently from 4f81c7b to f1525e7 Compare June 13, 2024 04:07
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@AaronHForgeFlow
Copy link
Contributor

@AungKoKoLin1997 can you please rebase so runboat is rebuilt? Thanks

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from f1525e7 to 3033869 Compare October 14, 2024 13:30
@AungKoKoLin1997
Copy link
Contributor Author

@AaronHForgeFlow I rerun the runboat.

AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@AungKoKoLin1997
Copy link
Contributor Author

@rousseldenis Can we get this PR merged?

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1465-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 15, 2024
@OCA-git-bot
Merge PR #1465 into 16.0
82fa5e0 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1465-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

carlosdauden and others added 27 commits December 19, 2024 02:38
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Remove unnecessary rounds.
b4fee13
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Remove update_enabled.
175f0e4
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Simplify code and black style
48d2bc8
@carlosdauden @nobuQuartile
[FIX] product_cost_price_avco_sync: Value field are not in dict
cd5f18f
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Compare unit_cost field with curr…
2d04d69 
…ency precision
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Remaining quantities
9ea8dee
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Simplify code
ebceb23
@sergio-teruel @nobuQuartile
[IMP] product_cost_price_avco_sync: Remove unneeded quantity in vals
850249d
@sergio-teruel @nobuQuartile
[IMP] product_cost_price_avco_sync: variable unit cost processed afte…
aed578c 
…r first adjustment input
@carlosdauden @nobuQuartile
[FIX] product_cost_price_avco_sync: Change Monetary fields to Float (…
fd587a5 
…20,8)
@carlosdauden @nobuQuartile
[FIX] product_cost_price_avco_sync: Incorrect unit_cost when we have …
bcd3e1d 
…negative stock and vacuum with sale return move

TT33334
@sergio-teruel @nobuQuartile
[FIX] product_cost_price_avco_sync: Create SVL for new stock move lines
c7d0652
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Use regex to extract price from d…
e2003b6 
…escription
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Compatibility with landed cost
2e0871b
@pedrobaeza @nobuQuartile
[FIX] product_cost_price_avco_sync: Don't fail on missing description
07f34a6
@carlosdauden @nobuQuartile
Revert "[FIX] product_cost_price_avco_sync: Change Monetary fields to…
0f13789 
… Float (20,8)"

This reverts commit ace19f5
@CarlosRoca13 @nobuQuartile
[IMP] product_cost_price_avco_sync: black, isort, prettier
d79d352
@CarlosRoca13 @nobuQuartile
[MIG] product_cost_price_avco_sync: Migration to 15.0
b7d65e6
@pedrobaeza @nobuQuartile
[REF] product_cost_price_avco_sync: refactor for having hooks
e19a6d5
@carlosdauden @nobuQuartile
[IMP] product_cost_price_avco_sync: Set zero instead of insignificant…
90c5fc4 
… values to avoid full processing in case remaining_qty contains an insignificant value less than zero
@CarlosRoca13 @nobuQuartile
[IMP] product_cost_price_avco_sync: Add preprocess_svl_dict
79576d3 
With this dict we are allowed to process some svls before
processing the main avoiding do writes on the method.

TT44663
@weblate @nobuQuartile
Update translation files
f6fb8d1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/
@josep-tecnativa @nobuQuartile
[IMP] product_cost_price_avco_sync: test performance improvement
bb41383 
- Include context keys for avoiding mail operations overhead.
@Ivorra78 @nobuQuartile
Translated using Weblate (Spanish)
1ccd409 
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/es/
@mymage @nobuQuartile
Added translation using Weblate (Italian)
7a11628
@AungKoKoLin1997 @nobuQuartile
[IMP] product_cost_price_avco_sync: pre-commit stuff
fc7d029
@AungKoKoLin1997 @nobuQuartile
[MIG] product_cost_price_avco_sync: Migration to 16.0
2c88de8
@nobuQuartile nobuQuartile force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 3033869 to 2c88de8 Compare December 19, 2024 02:38
@nobuQuartile
Copy link

nobuQuartile commented Dec 19, 2024 •
edited
Loading

Lin will be out of the office for another month; therefore, I will reply on his behalf.
We have completed the rebase process.
Unfortunately, this module is no longer in use, making it challenging to provide a meaningful description. We apologize for any inconvenience caused.
I kindly request that other contributors consider working on this module if they are interested in doing so.
Thank you in advance for your understanding.

@pedrobaeza
Copy link
Member

Note that there's a big refactoring at #1697 to speed up the synchronization, neutralize other bad behaviors, etc that should be taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.