[16.0][FIX] stock_lock_lot fix: fixed permissions issue when creating product categories #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLAlvaroGomez
changed the title
| def _check_category_lock_unlock(self): | ||
| if not self.user_has_groups("stock_lock_lot.group_lock_lot"): | ||
| def _check_category_lock_unlock(self, vals): | ||
| if self.lot_default_locked != vals and not self.user_has_groups( |
There was a problem hiding this comment.
@FLAlvaroGomez My question here: why is the constrains() trigger if the value hasn't changed ?
There was a problem hiding this comment.
@rousseldenis Updated, now the write method checks if the attribute changes to avoid executing the _check_category_lock_unlock method unnecessarily
There was a problem hiding this comment.
@rousseldenis can see the error in the video made in runbot.
Runboat-builds.webm
FLAlvaroGomez
force-pushed
the
16.0-fix-stock_lock_lot
branch
from
39687f0 to
c84b8a5
Compare
FLAlvaroGomez
changed the title
Fix permissions issue when creating product categories
FLAlvaroGomez
force-pushed
the
16.0-fix-stock_lock_lot
branch
from
f9d4caa to
35ea60c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix permissions validation when changing 'lot_default_locked' field
The permission checks for modifying the lot_default_locked field has been improved. Now, the system compares the current value of lot_default_locked with the new value being set and ensures the user has the necessary permissions (stock_lock_lot.group_lock_lot) before allowing the change. This prevents unauthorized users from blocking or unblocking serial numbers/lots.