-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] stock_release_channel: track release_channel_id
on stock.picking
#813
[16.0][IMP] stock_release_channel: track release_channel_id
on stock.picking
#813
Conversation
Hi @sebalix, |
@IT-Ideas change name to [16.0][IMP] stock_release_channel: track release_channel_id on stock.picking |
Hello @RodrigoBM, are you talking about the PR name or the commit title? In the commit history I don't find any with this pattern. Am I missing something? |
release_channel_id
on stock.picking
release_channel_id
on stock.picking
PR name, I haven't found this in the documentation, but you can see these example PR names |
@IT-Ideas Can you rebase? The fix for failing test has been merged. |
Yep but it seems that 16.0 is still red. Should I still do it? |
@RodrigoBM When doing an imporvement, it's better to not include the version number in commit message as the fix is often transversal to several versions. This allows to be forwardported or backported flawlessly. |
@IT-Ideas Could you rebase ? |
…king` This commit adds the changes tracking on `release_channel_id` of `stock_picking`
390f23e
to
17fd18a
Compare
Here you go @rousseldenis 🙂 |
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 68c1246. Thanks a lot for contributing to OCA. ❤️ |
This commit adds the changes tracking on
release_channel_id
ofstock_picking