Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] stock_release_channel: track release_channel_id on stock.picking #813

Merged

Conversation

IT-Ideas
Copy link

This commit adds the changes tracking on release_channel_id of stock_picking

@OCA-git-bot
Copy link
Contributor

Hi @sebalix,
some modules you are maintaining are being modified, check this out!

@RodrigoBM
Copy link
Contributor

RodrigoBM commented Jan 17, 2024

@IT-Ideas change name to [16.0][IMP] stock_release_channel: track release_channel_id on stock.picking

@IT-Ideas
Copy link
Author

@IT-Ideas change name to [16.0][IMP] stock_release_channel: track release_channel_id on stock.picking

Hello @RodrigoBM, are you talking about the PR name or the commit title? In the commit history I don't find any with this pattern. Am I missing something?

@IT-Ideas IT-Ideas changed the title [IMP] stock_release_channel: track release_channel_id on stock.picking [16.0][IMP] stock_release_channel: track release_channel_id on stock.picking Jan 17, 2024
@RodrigoBM
Copy link
Contributor

RodrigoBM commented Jan 17, 2024

@IT-Ideas change name to [16.0][IMP] stock_release_channel: track release_channel_id on stock.picking

Hello @RodrigoBM, are you talking about the PR name or the commit title? In the commit history I don't find any with this pattern. Am I missing something?

PR name, I haven't found this in the documentation, but you can see these example PR names

Selección_670

@jbaudoux
Copy link
Contributor

@IT-Ideas Can you rebase? The fix for failing test has been merged.

@IT-Ideas
Copy link
Author

@IT-Ideas Can you rebase? The fix for failing test has been merged.

Yep but it seems that 16.0 is still red. Should I still do it?

@rousseldenis
Copy link
Contributor

@IT-Ideas change name to [16.0][IMP] stock_release_channel: track release_channel_id on stock.picking

Hello @RodrigoBM, are you talking about the PR name or the commit title? In the commit history I don't find any with this pattern. Am I missing something?

PR name, I haven't found this in the documentation, but you can see these example PR names

Selección_670

@RodrigoBM When doing an imporvement, it's better to not include the version number in commit message as the fix is often transversal to several versions. This allows to be forwardported or backported flawlessly.

@rousseldenis
Copy link
Contributor

@IT-Ideas Could you rebase ?

…king`

This commit adds the changes tracking on `release_channel_id` of
`stock_picking`
@IT-Ideas IT-Ideas force-pushed the 16.0-add_release_channel_id_tracking-lst branch from 390f23e to 17fd18a Compare February 1, 2024 13:21
@IT-Ideas
Copy link
Author

IT-Ideas commented Feb 1, 2024

Here you go @rousseldenis 🙂

@rousseldenis
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-813-by-rousseldenis-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 82bd9c4 into OCA:16.0 Feb 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 68c1246. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants