-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate test dependencies and update docs #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nberth
force-pushed
the
update-build-docs
branch
2 times, most recently
from
November 2, 2023 09:06
936d280
to
a594a13
Compare
Moves the corresponding opam file to `test/opam`. This effectively removes a build-dependency to `autofonce_lib`, that should only be needed for development (installed via `make dev-deps`). Also move all test dependency declarations to `test/opam/superbol_testutils.opam`, now also considered by `dev-deps`. Remove dependency to `ocamlformat`, that we don't use.
nberth
force-pushed
the
update-build-docs
branch
from
November 2, 2023 10:01
a594a13
to
cfe3625
Compare
nberth
force-pushed
the
update-build-docs
branch
from
November 2, 2023 10:35
8e9337e
to
60ac3aa
Compare
nberth
added
documentation
Improvements or additions to documentation
ok to review
As its name says
labels
Nov 2, 2023
bclement-ocp
approved these changes
Nov 2, 2023
Co-authored-by: Basile Clément <129742207+bclement-ocp@users.noreply.github.com>
nberth
force-pushed
the
update-build-docs
branch
from
November 2, 2023 20:43
6b56d23
to
a5580b7
Compare
nberth
force-pushed
the
update-build-docs
branch
from
November 2, 2023 21:30
a5580b7
to
f503a69
Compare
GitMensch
reviewed
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some notes (will later try to update the gitpod configuration using the new instructions, but that will likely take some days...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily updates the documentation on how to build from sources and install the VSCode extension.
As a bonus, dependencies that are only needed for tests are removed from library and program packages, and gathered into a separate
superbol-testdeps
package (for now, managed manually, i.e outside ofdrom
's realm). This effectively means thatmake build-deps
should not installautofonce_lib
or other test-related PPXs anymore. From now on,make dev-deps
is needed to install them.Changes also include the creation of a virtual
superbol-studio-oss
package that depends on both the LSP server and the VSCode extension (for clarity), and removal of obsolete opam files.