-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix per-file project-loading #109
Conversation
ece4162
to
52eb68f
Compare
d43bb6b
to
37ad445
Compare
37ad445
to
d091b8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files vSCode_extension.ml{,i}
should probably be called vscode_extension.ml{,i}
instead. vSCode_extension.ml{,i}
is really ugly; VSCode_extension.ml{,i}
would be fine, but there are other references to Vscode
using this case (e.g. Vscode_json
, Vscode_languageclient
) and consistency matters.
Yes, I am planning to rename all of those other ulgy file names. The name of the module matters (and should be VSCode`), not the name of the file. |
I can change to |
We will disagree here because I think that using |
Hum, I always though VSCode was written like this (but I don't use it myself so I never checked). (At this point it should be clear that aesthetics, which is very subjective, also matter in choosing module names ;-) — I was much less comfortable with having |
e4235ea
to
23ba10e
Compare
Includes fixes to project directory lookup for
indent
sub-commands, as well as some basic renaming of modules to have a meaningfulSuperbol_free_lib.Project
module.