Fix completion failing in some parser states #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoKaios
force-pushed
the
fix/failing-completion
branch
2 times, most recently
from
802404e to
3275050
Compare
|
@NeoKaios I feel removing "semantic" completion on point-wise locations is a bit harsh (as exemplified by the test inputs you needed to change in this PR). I think we can accept some level of "wrong suggestions" in a restricted set of cases if the suggestions are quite accurate "in general". |
NeoKaios
force-pushed
the
fix/failing-completion
branch
from
02e4239 to
c1d49ed
Compare
nberth
reviewed
Aug 6, 2024
nberth
reviewed
Aug 9, 2024
When skipping folding steps, the folder could set the type to a previous context and not fold over a hidden Any context
Unstring _ into _|_ should be Any not Alphanum type_at_pos takes the last valid type since there is no recovery after the into
This reverts commit 3275050.
NeoKaios
force-pushed
the
fix/failing-completion
branch
from
7502a7f to
46a4ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.