Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax order of paragraphs in CONFIGURATION SECTION #331

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

NeoKaios
Copy link
Contributor

@NeoKaios NeoKaios commented Jul 26, 2024

Closes #269

@NeoKaios
Copy link
Contributor Author

Not sure this is the correct way of doing it....

@nberth
Copy link
Collaborator

nberth commented Jul 26, 2024

Not sure this is the correct way of doing it....

Thankfully the combinatorics would be on your side with this approach. However, I'd rather keep the order of declarations consistent between the input and the parse-tree. So relaxing the order should be done by altering the parse-tree types, using a list of paragraphs (and relying on an additional check for duplicates, maybe left for later). We do something similar for the sections in the DATA DIVISION.

@NeoKaios NeoKaios force-pushed the feat/relax-order-env-paragraph branch from 56cb047 to a943b9f Compare July 29, 2024 10:24
@GitMensch
Copy link
Contributor

Note: this is only part of the issue, MF (and likely others) also allow INPUT-OUTPUT and CONFIGURATION sections being in wrong order, which we just recently added to GnuCOBOL - you likely want to relax the order there in this PR as well

@NeoKaios NeoKaios marked this pull request as draft July 30, 2024 13:38
@NeoKaios NeoKaios force-pushed the feat/relax-order-env-paragraph branch from a943b9f to e9d5057 Compare July 30, 2024 15:07
@NeoKaios NeoKaios force-pushed the feat/relax-order-env-paragraph branch from 2118d34 to b6ee715 Compare August 5, 2024 14:13
@NeoKaios NeoKaios marked this pull request as ready for review August 6, 2024 07:12
CHANGELOG.md Outdated Show resolved Hide resolved
@nberth nberth merged commit 423512f into OCamlPro:master Aug 6, 2024
4 checks passed
@NeoKaios NeoKaios deleted the feat/relax-order-env-paragraph branch August 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax order of paragraphs in the ENVIRONMENT DIVISION
3 participants