Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify pp_token of Text_tokenizer with other pp #346

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Unify pp_token of Text_tokenizer with other pp #346

merged 4 commits into from
Aug 9, 2024

Conversation

NeoKaios
Copy link
Contributor

@NeoKaios NeoKaios commented Aug 6, 2024

The old pp_token of Text_tokenizer didn't have a prime even though it was a pretty printer for token with_loc

nberth
nberth requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only change that is actually needed it the addition or removal of primes for pp_token functions. The rest makes things just a little bit too messy.

@NeoKaios NeoKaios force-pushed the refactor/cleanup-pp-token branch from cc0c52c to 154528c Compare August 8, 2024 08:21
nberth
nberth approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fan of the change to the type names. In the context of the scanner/parser, type token = … with_loc was fine. The main issue was only in the name of pretty-printing functions that are exported by the library. But ok anyways.

@NeoKaios NeoKaios force-pushed the refactor/cleanup-pp-token branch from 154528c to ad4a7b8 Compare August 8, 2024 10:42
@NeoKaios NeoKaios force-pushed the refactor/cleanup-pp-token branch from 9e8450a to 1f88e82 Compare August 9, 2024 07:34
nberth
nberth approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nberth nberth merged commit 8b26d76 into OCamlPro:master Aug 9, 2024
4 checks passed
@NeoKaios NeoKaios deleted the refactor/cleanup-pp-token branch August 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nberth nberth nberth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeoKaios @nberth