-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix form for customizing superbol.path
#72
Conversation
This form seemed to show correctly to me before. Was there a specific issue with its rendering? While we are at it, is there a way to be more specific, and, for instance, tell it's a(n existing) directory that we'd want in this field? |
On my side, it displays a link to the settings.json file to edit the option manually. Which version of vscode do you use? I am using 1.82.2.
I'm trying to make variable substitution work, the doc says something like |
Hum not good news: I'm using 1.80.0. So I assume the current specs are a just becoming out-dated. |
Variable substitution does not seem to work either on the last version (1.83.1), it would have been too easy 😅 |
Good thing, though: putting EDIT : #75 adresses the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always good to follow the specs for package.json :-)
Please improve the one description and the types for the others.
@@ -21,6 +21,7 @@ | |||
"description": "If something is selected, only format the selection" | |||
}, | |||
"superbol.path": { | |||
"type": "string", | |||
"default": "", | |||
"description": "Path to the `superbol` command" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please adjust that, maybe something like "name of superbol
command/binary to use, may be full path", at least that would tell me that I can either use something that's on the environment specific PATH or a full path.
src/lsp/superbol_free_lib/project.ml
Outdated
~description: "Path to the `superbol` command" | ||
~description: | ||
"Name of the `superbol` command; path can be relative (deprecated) or \ | ||
absolute." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to convey the idea that one can put an executable name that will be searched in PATH
. Is it actually allowed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is allowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'd suggest something like "Name of the superbol
executable if available in PATH; otherwise, may be an absolute path."
@nberth If you want changes to this PR then please review requesting changes. Otherwise I suggest to pull this in to get the type error fixed (we can easily adjust the description later). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion and we can pull this in ;-)
src/lsp/superbol_free_lib/project.ml
Outdated
~description: "Path to the `superbol` command" | ||
~description: | ||
"Name of the `superbol` command; path can be relative (deprecated) or \ | ||
absolute." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'd suggest something like "Name of the superbol
executable if available in PATH; otherwise, may be an absolute path."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button on previous review: actually requesting a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge after fixing typo ;-)
superbol.path
This PR fixes the
superbol.path
form that was not displayed because of a type error.