Only enable indenter on free format #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indenter also now uses inferred formats properly. Fixes OCamlPro#52
nberth
reviewed
Oct 26, 2023
|
You probably want to pass a |
I'm sure you meant |
bclement-ocp
changed the title
nberth
approved these changes
Oct 27, 2023
| @@ -23,7 +23,9 @@ let doc = {cobol| | |||
| |cobol};; | |||
|
|
|||
| let%expect_test "simple-formatting-request" = | |||
| let { projdir; end_with_postproc }, server = make_lsp_project () in | |||
| let { projdir; end_with_postproc }, server = | |||
| make_lsp_project ~toml:"source-format = \"free\"\n" () | |||
There was a problem hiding this comment.
This could have deserved a little make_free_format_lsp_project shortcut to avoid duplication.
There was a problem hiding this comment.
It could, but I believe test code deserves to be as plain as possible, hence I did not do that -- in fact there is much code duplication between the test cases already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indenter also now uses inferred formats properly.
Fixes #52
Note: Currently includes #73; do not merge before #73.