Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Inactive and archived entities to indexable #422

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Made Inactive and archived entities to indexable #422

wants to merge 17 commits into from

Conversation

Naveen-Pal
Copy link
Collaborator

Resolves #369

Modify the is_indexable() function to allow inactive and archived entities.
Modified the corresponding tests.

@Naveen-Pal Naveen-Pal requested a review from arkid15r as a code owner January 11, 2025 15:44
arkid15r
arkid15r requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indexing part looks good.
Now in order to keep the search results consistent we need to rank inactive entities the lowest. Please add is_active attribute and adjust the customRanking rules to use it as the very first one.

@Naveen-Pal Naveen-Pal requested a review from arkid15r January 12, 2025 18:21
@Naveen-Pal
Copy link
Collaborator Author

@arkid15r Please review the PR

@Naveen-Pal
Copy link
Collaborator Author

@arkid15r . Please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
backend backend-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index OWASP inactive/archived entities
2 participants
@Naveen-Pal @arkid15r