Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'Is_indexable' and similar property from models to models/mixins #437

Closed
wants to merge 0 commits into from
Closed

Move 'Is_indexable' and similar property from models to models/mixins #437

wants to merge 0 commits into from

Conversation

bhagyashree980
Copy link
Collaborator

Resolves #351

arkid15r
arkid15r requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has conflicts.

@arkid15r arkid15r marked this pull request as draft January 13, 2025 05:02
@arkid15r
Copy link
Collaborator

@bhagyashree980 any updates on this?

@bhagyashree980 bhagyashree980 force-pushed the 12ka4 branch 2 times, most recently from a752087 to a4b2afd Compare January 17, 2025 20:28
@bhagyashree980 bhagyashree980 marked this pull request as ready for review January 17, 2025 20:30
arkid15r
arkid15r requested changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code contains unrelated changes that needs to be removed. Make sure you submit only related changes before re-requesting review.

Please also note that the tasks is to refactor this for all indexable models.

@bhagyashree980 bhagyashree980 force-pushed the 12ka4 branch 7 times, most recently from 908722e to 7ce28eb Compare January 22, 2025 19:23
@arkid15r arkid15r marked this pull request as draft January 23, 2025 00:43
@bhagyashree980 bhagyashree980 force-pushed the 12ka4 branch 2 times, most recently from fc258c7 to 3d2e0fc Compare January 23, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r requested changes

@kasya kasya Awaiting requested review from kasya

Assignees
No one assigned
Labels
backend deploy documentation Improvements or additions to documentation frontend frontend-tests makefile nestbot nestbot-tests nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move is_indexable properties from models to models/mixins
2 participants
@bhagyashree980 @arkid15r