Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/CWE 798 #136

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Feature/CWE 798 #136

merged 3 commits into from
Jan 6, 2024

Conversation

timmyteo
Copy link
Contributor

@paul-ion let me know your thoughts on this new yellow belt challenge. You mentioned this could be a good addition. I am happy to make any changes that make sense. In particular, I am wondering:

  • Do you think the HTML page description (not the solution markdown) needs a hint like: "A .jar file is an archive/collection of other files"?
  • Does the attack gram look good or is there a better representation for this CWE?
  • I edited the attack gram powerpoint with LibreOffice, so hoping that doesn't mess up formatting of existing slides, when viewed in Microsoft Powerpoint
  • Do you think the code block associated to this challenge is accurate?
  • Is the location of the validate.jar file in the website structure a good place, or is there a better place it should live, being a static file that needs to be available for download?
  • Should the .java and .properties files which compose the contents of the validate.jar file be stored somewhere in this repository, in case the challenge needs updates in the future? Presently I am not including them in this pull request.
  • Should a question be added to the final quiz in relation to this new challenge?

@paul-ion
Copy link
Collaborator

Thank you for the PR, @timmyteo. It looks great!

We don't have a code block for Hard-Coded Credentials but I think the one you used is the closest. It does speak about changing credentials across environments which implies that hardcoded creds should not be used.

As far as placing the script file it can go in the /resources/ folder next to the .c files used for the memory challenges.

Thanks again for your contributions! I really appreciate your interest in the project.

@timmyteo
Copy link
Contributor Author

Thanks @paul-ion, I added the .jar supporting files to the resources folder.

@paul-ion paul-ion merged commit 6dba519 into OWASP:main Jan 6, 2024
2 checks passed
@paul-ion
Copy link
Collaborator

paul-ion commented Jan 6, 2024

Many thanks @timmyteo !

@timmyteo timmyteo deleted the feature/cwe-798 branch February 3, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants