Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new net48 build target #776

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Add new net48 build target #776

merged 5 commits into from
Oct 9, 2023

Conversation

scme0
Copy link
Contributor

@scme0 scme0 commented Oct 9, 2023 •
edited
Loading

To allow us to upgrade OctopusClient in OctopusTentacle, we need to support .Net Framework 4.8

Unfortunately when we try and use the .Net Framework 4.6.2 we get some versioning issues with System.Net.Http.

In testing, creating a .Net Framework 4.8 version in the Nuget package eliminated the issues.

@scme0 scme0 marked this pull request as ready for review October 9, 2023 04:09
APErebus
APErebus approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@APErebus APErebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@scme0 scme0 mentioned this pull request Oct 9, 2023
Closed
tekerson
tekerson approved these changes Oct 9, 2023
View reviewed changes
Copy link

@tekerson tekerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the relevant tests. It looks like this has had a pretty thorough manual vetting too!

@scme0 scme0 merged commit 632796a into master Oct 9, 2023
@scme0 scme0 deleted the scme/net48 branch October 9, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APErebus APErebus APErebus approved these changes

@tekerson tekerson tekerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scme0 @tekerson @APErebus