Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to master and adapt genesis transactions for runtime api #141

Closed
wants to merge 14 commits into from

Conversation

JoshOrndorff
Copy link
Contributor

@JoshOrndorff JoshOrndorff commented Nov 15, 2023

(This began as an attempt to simply update the sdk to v1.3.0, but that effort was spun off into #145.)

This PR begins to revise the design of our genesis block builder to reflect the changes in paritytech/polkadot-sdk#1256

Perhaps we can also avoid writing the genesis transactions temporarily to the storage, but I haven't tried that yet.

@JoshOrndorff
Copy link
Contributor Author

Here's where I'm at right now

$ ./target/release/node-template --dev
2023-11-17 22:52:35 Tuxedo Template Node    
2023-11-17 22:52:35 ✌️  version 4.0.0-dev-73db1a96554    
2023-11-17 22:52:35 ❤️  by , 2023-2023    
2023-11-17 22:52:35 📋 Chain specification: Development    
2023-11-17 22:52:35 🏷  Node name: direful-sheet-3762    
2023-11-17 22:52:35 👤 Role: AUTHORITY    
2023-11-17 22:52:35 💾 Database: ParityDb at /tmp/substratezGuy3g/chains/dev/paritydb/full    
Error: Service(Client(Storage("wasm call error Other: Exported method GenesisBuilder_create_default_config is not found")))

@JoshOrndorff
Copy link
Contributor Author

Made it a little further:

$ ./target/release/node-template --dev
2023-11-18 01:08:55 Tuxedo Template Node    
2023-11-18 01:08:55 ✌️  version 4.0.0-dev-19339dd1ba3    
2023-11-18 01:08:55 ❤️  by , 2023-2023    
2023-11-18 01:08:55 📋 Chain specification: Development    
2023-11-18 01:08:55 🏷  Node name: unwieldy-queen-4551    
2023-11-18 01:08:55 👤 Role: AUTHORITY    
2023-11-18 01:08:55 💾 Database: ParityDb at /tmp/substrateC6KQW8/chains/dev/paritydb/full    
Error: Service(Client(Storage("Invalid JSON blob: invalid type: null, expected struct TuxedoGenesisConfig at line 1 column 4")))

Copy link

Coverage after merging joshy-update-sdk-to-1.3.0 into main will be

63.48%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
tuxedo-core/aggregator/src
   lib.rs99.28%100%100%99.26%117, 21
tuxedo-core/no_bound/src
   clone_no_bound.rs36.63%100%30%37.36%24, 32–39, 56, 59–72, 74–87, 89, 91–95, 98–99
   debug_no_bound.rs32.73%100%30%33%101–105, 108–109, 24, 32–42, 58, 60–78, 80–95, 97–99
   default_no_bound.rs19.11%100%16.67%19.31%100–122, 124–131, 133, 136–147, 151–157, 32–39, 51, 54–80, 83–88, 91–99
   lib.rs100%100%100%100%
tuxedo-core/src
   constraint_checker.rs50.59%100%47.37%51.52%71–91, 93–95
   dynamic_typing.rs84.75%100%72.73%89.41%
   executive.rs91.49%100%92.68%91.34%116, 142, 175, 207, 220–228, 236, 247, 298, 325, 376–381, 383, 393–394, 399–400, 403, 405–406, 409–410, 412, 416–437, 439, 443–444, 446–447, 449, 452–469, 54
   genesis.rs23.08%100%37.50%21.88%100–105, 108, 174–180, 182, 184–193, 195–202, 205–206, 43–56, 68, 70–73, 75–76, 78–80, 83–87, 89–91, 93–99
   inherents.rs7.62%100%12.50%6.74%119–121, 156, 162–176, 178–201, 209–214, 216–220, 223–225, 227, 56–58, 63–68, 70–78, 81, 83
   types.rs71.35%100%54.35%76.98%86, 88–91, 93–99
   utxo_set.rs90.91%100%100%88.89%39–40
   verifier.rs88.01%100%71.60%92.28%120
tuxedo-template-runtime/src
   genesis.rs87.74%100%90%87.59%24–41
   lib.rs4.30%100%13.04%2.57%122, 125, 130–132, 136–138, 149, 151, 153, 155, 157, 159, 161, 163, 165, 168, 170, 175, 184–205, 208–235, 238–368, 58–63, 94–99
wallet/src
   amoeba.rs0%100%0%0%100–106, 109–110, 112–118, 120–127, 19–48, 51–52, 54–99
   cli.rs0%100%0%0%103, 108, 119, 125, 14, 17, 19, 28, 33, 38, 45, 56, 68, 91
   keystore.rs0%100%0%0%31–33, 38–45, 47–48, 51, 53–59, 65–73, 76–78, 80–82, 85–91, 93–94
   main.rs0%100%0%0%101–102, 105–117, 120, 122–126, 129–133, 135–144, 146–147, 151–161, 164–165, 167, 170–171, 173, 175, 177–180, 182–184, 186, 190–197, 200–203, 205–207, 210–212, 214, 216, 219–225, 228–241, 244–247, 249–259, 26, 260, 262, 27–30, 33, 36–38, 40–41, 44, 46, 48–49, 53, 56–62, 65, 67–69, 73–76, 78, 80, 82–83, 86–87, 89, 91–93, 98–99
   money.rs0%100%0%0%100–101, 105, 109–112, 114, 119–125, 127–131, 134–135, 139–144, 146–147, 22–28, 31–49, 53–59, 65–72, 74, 78–83, 87, 90, 92, 95–98
   output_filter.rs100%100%100%100%
   rpc.rs0%100%0%0%16–21, 24–26, 28–44, 47–53, 55–58, 60–61
   sync.rs0%100%0%0%103–106, 113–114, 116, 119–122, 127–129, 132–133, 136–141, 143–145, 148, 150–151, 156–159, 162–163, 170–174, 176–182, 185–187, 189–190, 193–194, 199–202, 205, 207–208, 213–216, 219, 221–222, 225–231, 233–234, 237–238, 241–242, 245–246, 250–256, 259–263, 266–268, 271–279, 281, 285, 287–288, 291–292, 295–302, 304–305, 308–309, 311, 313–314, 318–320, 322–323, 325–326, 328–329, 332–334, 336–337, 339–340, 342–343, 347, 349–350, 354, 356–361, 364–365, 368–370, 373, 376–379, 381, 384–387, 390, 393–394, 397–398, 403–408, 410, 412, 417–420, 423–424, 427–432, 434, 437–438, 442–443, 445, 447–449, 451–454, 457–458, 46–50, 54, 57–58, 61, 63–77, 82–86, 88–89, 94–99
wardrobe/amoeba/src
   lib.rs59.06%100%26.83%71.30%121, 139, 178, 81
   tests.rs100%100%100%100%
wardrobe/kitties/src
   lib.rs48.13%100%26.45%57.50%100, 102–103, 106–109, 117–119, 121–123, 127–129, 133–134, 137–139, 143–145, 150–152, 154–155, 159–161, 172–192, 211–212, 215–222, 225, 228, 230, 232, 234, 236, 238, 240, 242, 244, 246, 248, 250, 252, 254, 256, 258, 260, 262, 391, 40–42, 423, 426, 44–48, 486, 49–51, 56–58, 60–62, 65–68, 77–79, 81–83, 86–89, 98–99
   tests.rs99.61%100%98.25%99.78%
wardrobe/money/src
   lib.rs50%100%22.45%62.39%102–103, 106–113, 116, 119, 121, 123, 127, 130, 133, 191, 22–24, 33–35, 37–38, 41–44, 47, 51, 60–62, 64–66, 69–71
   tests.rs100%100%100%100%
wardrobe/poe/src
   lib.rs0%100%0%0%100, 108–112, 116–117, 121–122, 128, 134–139, 141–143, 147–151, 153–154, 167, 173–179, 39, 52, 55, 57, 59, 61, 65, 84,

@JoshOrndorff JoshOrndorff changed the title Update sdk to 1.3.0 Update SDK to master and adapt genesis transactions for runtime api Nov 21, 2023
@muraca
Copy link
Collaborator

muraca commented Nov 23, 2023

superseded by #151

@muraca muraca closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants