Skip to content

Commit

Permalink
feat: Update publish UX for go production (#13083)
Browse files Browse the repository at this point in the history
  • Loading branch information
Yimin-Jin authored Jan 21, 2025
1 parent 3ace65c commit 7dc3b28
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 11 deletions.
5 changes: 3 additions & 2 deletions packages/fx-core/resource/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,9 @@
"core.selectLocalTeamsAppManifestQuestion.title": "Select local Teams manifest.json file",
"core.selectCollaborationAppTypeQuestion.title": "Select the app for which you want to manage collaborators",
"core.selectValidateMethodQuestion.validate.selectTitle": "Select a validation method",
"core.selectValidateMethodQuestion.validate.schemaOption": "Validate using manifest schema",
"core.selectValidateMethodQuestion.validate.appPackageOption": "Validate app package using validation rules",
"core.selectValidateMethodQuestion.validate.schemaOption": "Validate Teams app manifest schema",
"core.selectValidateMethodQuestion.validate.appPackageOption": "Validate app package using Teams Store rules",
"core.selectValidateMethodQuestion.validate.appPackageOptionDescription": "Validate Teams app before publishing Teams app to Teams store",
"core.selectValidateMethodQuestion.validate.testCasesOption": "Validate all integration test cases before publishing",
"core.selectValidateMethodQuestion.validate.testCasesOptionDescription": "Comprehensive tests to ensure readiness",
"core.confirmManifestQuestion.placeholder": "Confirm you've selected the correct manifest file",
Expand Down
5 changes: 4 additions & 1 deletion packages/fx-core/src/question/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1103,13 +1103,16 @@ export class TeamsAppValidationOptions {
return {
id: "validateAgainstPackage",
label: getLocalizedString("core.selectValidateMethodQuestion.validate.appPackageOption"),
detail: getLocalizedString(
"core.selectValidateMethodQuestion.validate.appPackageOptionDescription"
),
};
}
static testCases(): OptionItem {
return {
id: "validateWithTestCases",
label: getLocalizedString("core.selectValidateMethodQuestion.validate.testCasesOption"),
description: getLocalizedString(
detail: getLocalizedString(
"core.selectValidateMethodQuestion.validate.testCasesOptionDescription"
),
};
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@
},
{
"command": "fx-extension.openDocumentLink",
"when": "view == teamsfx-utility && viewItem =~ /^fx-extension.(build|publishInDeveloperPortal)$/",
"when": "view == teamsfx-utility && viewItem =~ /^fx-extension.(validateManifest|publishInDeveloperPortal)$/",
"group": "inline"
}
],
Expand Down
6 changes: 3 additions & 3 deletions packages/vscode-extension/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,9 @@
"teamstoolkit.commandsTreeViewProvider.publish.blockTooltip": "Unable to run command during package publishing. Try again after publishing completes.",
"teamstoolkit.commandsTreeViewProvider.publish.running": "Publishing in progress...",
"teamstoolkit.commandsTreeViewProvider.publishDescription": "Run the 'publish' lifecycle stage in teamsapp.yml file.",
"teamstoolkit.commandsTreeViewProvider.publishInDevPortalTitle": "Open Developer Portal to Publish",
"teamstoolkit.commandsTreeViewProvider.publishInDevPortalDescription": "Publish to your org in Developer Portal",
"teamstoolkit.commandsTreeViewProvider.publishTitle": "Publish",
"teamstoolkit.commandsTreeViewProvider.publishInDevPortalTitle": "Publish to store in developer portal",
"teamstoolkit.commandsTreeViewProvider.publishInDevPortalDescription": "Before publishing your app, we recommend to validate all integration test cases.",
"teamstoolkit.commandsTreeViewProvider.publishTitle": "Publish to org",
"teamstoolkit.commandsTreeViewProvider.getStartedTitle": "Get Started",
"teamstoolkit.commandsTreeViewProvider.reportIssuesDescription": "Report any issues and let us know your feedback",
"teamstoolkit.commandsTreeViewProvider.reportIssuesTitle": "Report Issues on GitHub",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ export const allSteps: () => NextStep[] = () => [
title: "Publish Your App",
description:
"After creating the app, you can distribute your app to different scopes, such as an individual, a team, or an organization. The distribution depends on multiple factors such as needs, business and technical requirements, and your goal for the app. Distribution to different scope may need different review processes. In general, the bigger the scope, the more review the app needs to go through for security and compliance concerns.",
docLink: "https://aka.ms/teamsfx-publish",
docLink: "https://aka.ms/publish-to-org",
commands: [
{
title: "Publish Your App",
Expand Down
3 changes: 1 addition & 2 deletions packages/vscode-extension/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ export enum CommandKey {

export const environmentVariableRegex = /\${{[a-zA-Z-_]+}}/g;

export const PublishAppLearnMoreLink =
"https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/deploy-and-publish/apps-publish-overview";
export const PublishAppLearnMoreLink = "https://aka.ms/teamsfx-publish";

export const DeveloperPortalHomeLink = "https://dev.teams.microsoft.com/home";

Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-extension/src/handlers/openLinkHandlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export async function openDocumentLinkHandler(args?: any[]): Promise<Result<bool
case "fx-extension.provision": {
return VS_CODE_UI.openUrl("https://aka.ms/teamsfx-provision-cloud-resource");
}
case "fx-extension.build": {
case "fx-extension.validateManifest": {
return VS_CODE_UI.openUrl("https://aka.ms/teams-store-validation");
}
case "fx-extension.deploy": {
Expand Down

0 comments on commit 7dc3b28

Please sign in to comment.