Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spfx scaffolding #12173

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: spfx scaffolding #12173

merged 1 commit into from
Aug 7, 2024

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented Aug 6, 2024

Bug 28940400: create SPFx project failed - test case 11042969

Fix issue #12143

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (20f071b) to head (b22e600).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #12173    +/-   ##
========================================
  Coverage   89.49%   89.49%            
========================================
  Files         572      572            
  Lines       33661    33663     +2     
  Branches     6604     6438   -166     
========================================
+ Hits        30124    30126     +2     
+ Misses       1582     1581     -1     
- Partials     1955     1956     +1     
Files Coverage Δ
...ent/generator/spfx/depsChecker/generatorChecker.ts 78.82% <100.00%> (ø)
.../component/generator/spfx/depsChecker/yoChecker.ts 79.12% <100.00%> (ø)
...core/src/component/generator/spfx/spfxGenerator.ts 88.08% <100.00%> (ø)
...x-core/src/component/generator/spfx/utils/utils.ts 55.75% <100.00%> (+0.79%) ⬆️

... and 2 files with indirect coverage changes

@yuqizhou77 yuqizhou77 marked this pull request as ready for review August 7, 2024 01:21
@yuqizhou77 yuqizhou77 merged commit 66d5dbf into dev Aug 7, 2024
27 of 28 checks passed
@yuqizhou77 yuqizhou77 deleted the yuqzho/spfx-shell branch August 7, 2024 02:08
HuihuiWu-Microsoft pushed a commit to HuihuiWu-Microsoft/TeamsFx that referenced this pull request Sep 25, 2024
huimiu pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants