Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Local Debug SSO Tab with .NET 9 #13069

Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix: Fix Local Debug SSO Tab with .NET 9 #13069

merged 4 commits into from
Jan 20, 2025

Conversation

Yimin-Jin
Copy link
Contributor

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (0ade4f8) to head (6cbae1c).
Report is 5 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #13069   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         583      583           
  Lines       34974    35049   +75     
  Branches     6823     6836   +13     
=======================================
+ Hits        31557    31627   +70     
- Misses       1489     1491    +2     
- Partials     1928     1931    +3     
Files with missing lines Coverage Δ
...c/component/generator/templates/ssrTabGenerator.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

huimiu
huimiu previously approved these changes Jan 20, 2025
{{/Net9Framework}}
{{#Net9Framework}}
app.MapRazorComponents<App>()
.AddInteractiveServerRenderMode(o => o.ContentSecurityFrameAncestorsPolicy = "'self' *");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also work in .net 8? If yes, let's make it consistent for both .net 9 and .net 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new feature in .net9, this function was not available in .net8.

@Yimin-Jin Yimin-Jin merged commit 5922727 into dev Jan 20, 2025
19 checks passed
@Yimin-Jin Yimin-Jin deleted the yimin/fix-vs-tab branch January 20, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants