perf: update swagger-parser version, remove workaround (#13025) #13080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* perf: update swagger-parser version, remove workaround * perf: update lock file * perf: update test cases * fix: test issue --------- Co-authored-by: rentu <rentu>
SLdragon
approved these changes
Jan 21, 2025
wenytang-ms
added
the
cherry-pick-hotfix
adashen
reviewed
Jan 21, 2025
| @@ -283,6 +286,11 @@ export class SpecParser { | |||
| } | |||
| } | |||
|
|
|||
| private async deReferenceSpec(spec: any): Promise<OpenAPIV3.Document> { | |||
adashen
reviewed
Jan 21, 2025
| @@ -90,8 +90,11 @@ export class SpecParser { | |||
| if (!this.parser.$refs.circular) { | |||
| await this.parser.validate(this.spec!); | |||
| } else { | |||
| // The following code still hangs for Graph API, support will be added when SwaggerParser is updated. | |||
There was a problem hiding this comment.
Seems no need to change here for the hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: update swagger-parser version, remove workaround
perf: update lock file
perf: update test cases
fix: test issue