Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use password input for API key and secret in DA #13081

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

SLdragon
Copy link
Contributor

No description provided.

@wenytang-ms wenytang-ms added the cherry-pick-hotfix hotfix that need to be merge into dev and release branch label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (9fc1ed0) to head (e6b5030).
Report is 2 commits behind head on release/5.12.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release/5.12   #13081   +/-   ##
=============================================
  Coverage         90.04%   90.04%           
=============================================
  Files               577      577           
  Lines             34198    34198           
  Branches           6820     6828    +8     
=============================================
  Hits              30794    30794           
  Misses             1501     1501           
  Partials           1903     1903           
Files with missing lines Coverage Δ
packages/fx-core/src/question/other.ts 85.04% <ø> (ø)

@adashen adashen merged commit 45fb5d9 into release/5.12 Jan 21, 2025
18 checks passed
@adashen adashen deleted the rentu-update121 branch January 21, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-hotfix hotfix that need to be merge into dev and release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants