Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: LoanConsolidator #32

Merged
merged 177 commits into from
Jan 14, 2025
Merged

Release: LoanConsolidator #32

merged 177 commits into from
Jan 14, 2025

Conversation

0xJem
Copy link
Collaborator

@0xJem 0xJem commented Jan 14, 2025 •
edited
Loading

0xJem added 30 commits September 26, 2024 16:17
@0xJem
Add tests for third-party clearinghouse/cooler and active status
0b142d4
@0xJem
Compile fix due to new constructor argument
51b25b4
@0xJem
Add checks for Clearinghouse, Cooler and active status. Renames some …
e97af50 
…events.
@0xJem
chore: linting
d7eaf09
@0xJem
Test stubs. Define additional admin address.
f06fef5
@0xJem
setAdmin: allow for zero address (to disable), prevent duplicating th…
6ff1b59 
…e owner address. Additional tests.
@0xJem
Minor test fix
d4c8282
@0xJem
Update docs
786cdbf
@0xJem
Set fee collector to TRSRY v1
5073418
@0xJem
Remove admin address, perform lookup of "emergency_shutdown" role.
5f3f6a4
@0xJem
Add initial version of EXREG module
8678136
@0xJem
NatSpec
29a6416
@0xJem
Test stubs
a061cd6
@0xJem
Implementation fixes. Complete tests.
593e005
@0xJem
Rename CoolerUtils -> LoanConsolidator. Move into policies directory.
089c233
@0xJem
Rename env key
b04be60
@0xJem
Convert LoanConsolidator to a policy
a0a7990
@0xJem
Update deployment and tests for LoanConsolidator
802e9b4
@0xJem
Refresh dependent policies when registering/deregistering contracts i…
b7f2e75 
…n EXREG
@0xJem
LoanConsolidator: Rename active state variable to be distinct from Po…
03c10e9 
…licy.isActive(). Add test stubs.
@0xJem
Fix formatter used by VSCode
79e12cf
@0xJem
Add policy to interface with EXREG
f491d0e
@0xJem
EXREG: force contract names to be lowercase or have a numeral
43c8571
@0xJem
Avoid stalling due to formatting on save
4eb7110
@0xJem
Document roles used
cb71371
@0xJem
LoanConsolidator: disable functions if the policy is not active
40efb96
@0xJem
LoanConsolidator: update tests to support conversion to policy
776933e
@0xJem
Fix regex for fork tests script
58cebc2
@0xJem
Add NatSpec on initialisation of state variables
dc5ff35
@0xJem
Rename _EXREG state variable to EXREG for consistency
a1b099c
0xJem and others added 27 commits December 10, 2024 13:11
@0xJem
Merge branch 'develop' into loan-consolidator
f96c9fe
@0xJem
Shift contract registry and loan consolidator proposal tests to use P…
bbcd90f 
…roposalTest
@0xJem
LoanConsolidator: upgrade CHREG to the latest version if v1.0 is dete…
cfb921f 
…cted during fork tests
@0xJem
Add additional tests for contract/policy active state
c1c1ffa
@0xJem
Use the contract address for the old CHREG version
f35eb2d
@0xJem
Update CHREG to latest version
8965a1f
@0xJem
Bump proposal ids
8cac9bc
@0xJem
Deployment of RGSTY and ContractRegistryAdmin contracts
f3f7276
@0xJem
Deployment for LoanConsolidator
be077d3
@0xJem
Assume installation batch script has been run during RGTSY proposal s…
d25b3d8 
…imulation
@0xJem
Assume installation batch script has been run during LoanConsolidator…
20f991b 
… proposal simulation
@0xJem
Update block for LoanConsolidator proposal
217051a
@0xJem
Update docs on proposal submission
334f1ae
@0xJem
Add support for Ledger when running OlyBatch scripts
d181a3e
@0xJem
Add missing environment variables for batch scripts
791d315
@0xJem
Logging in batches
5d119cf
@0xJem
Working batch script with Ledger
7b69dd0
@0xJem
Set sender address for proposal submission script
bc3dbfc
@0xJem
Mark ContractRegistryAdmin proposal as submitted (LoanConsolidator pr…
c296ff4 
…oposal will continue failing)
@0xJem
chore: linting
3130992
@0xJem
Update fork block for LoanConsolidator proposal test
eb79b15
@0xJem
Minor update to comment
ef01267
@0xJem
Correct argument to forge for setting the sender
64c825c
@0xJem
Mark proposal submission as true
9546ab5
@0xJem
Disable activation of LoanConsolidator policy during simulation
ee90017
@0xJem
Move the fork block so that tests pass
235af27
@0xJem
Merge pull request #19 from OlympusDAO/loan-consolidator
8d38928 
ContractRegistry module + LoanConsolidator
@0xJem 0xJem self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link

LCOV of commit 8d38928 during CI #120

Summary coverage rate:
  lines......: 69.4% (1365 of 1966 lines)
  functions..: 72.2% (296 of 410 functions)
  branches...: no data found

Files changed coverage rate: n/a

@0xJem 0xJem merged commit 4988650 into master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xJem @chefomi