Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors #773

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Fix CI errors #773

merged 6 commits into from
Dec 14, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Oct 23, 2023

Description

One Line Summary

Get the CI to succeed

Details

Motivation

Make the CI script useful

Scope

CI.yml
Formatting of code

Testing

Unit testing

pass now

Manual testing

tested running on iOS and Android

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the title WiP Fix CI errors Fix CI errors Oct 24, 2023
@emawby emawby changed the base branch from user_model/main to fix/clearTriggers_on_android October 24, 2023 18:51
Base automatically changed from fix/clearTriggers_on_android to user_model/main October 24, 2023 18:51
Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @jennantilla, @jkasten2, and @nan-li)

@shepherd-l shepherd-l merged commit 6bfc79a into user_model/main Dec 14, 2023
2 of 3 checks passed
@shepherd-l shepherd-l deleted the fix/ci branch December 14, 2023 20:30
nan-li pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants