-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use custom file lock functionality #314
Conversation
Nitpick: Do the locks need to persist through reboots? If not, what do you think of placing the lockfiles in This does not affect normal execution, but should address issues with the lock remaining if outside factors disrupt |
In addition to being able to run on the SD, one of our requirements is being able to run and use umu within a container framework, namely Flatpak and Snap. Those frameworks as well as their corresponding low level sandboxing tools can be configured so that $TMPDIR is a new private tmpfs and can be mounted at a different path. Having our lock files within umu’s host runtime directory avoids any special handling, and guarantees that a lock will always be held when sandboxed. |
a99db4a
to
3701c1c
Compare
umu-launcher currently depends on the filelock module to ensure that only 1 active umu-run process downloads Proton or the runtime. However, implementing file locking is relatively trivial and we do not care about cross platform file locking, async support, nor timeout support.