Allow overriding of identifier #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for e2e testing of OpenAssetIO/OpenAssetIO#1202. The upcoming hybrid plugin system will work by locating multiple plugins that all advertise the same unique identifier and combining them. In preparation for e2e testing of this, make BAL's plugin identifier configurable by an environment variable, so that it can be set to the same identifier as another plugin on the system. We cannot use other types of settings such as the JSON database, since the plugin identifier is queried before the settings are provided. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
force-pushed
the
work/OpenAssetIO/1202-configurableIdentifier
branch
from
0d2cfaf to
4040321
Compare
hutchinson
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for e2e testing of OpenAssetIO/OpenAssetIO#1202. The upcoming hybrid plugin system will work by locating multiple plugins that all advertise the same unique identifier and combining them.
In preparation for e2e testing of this, make BAL's plugin identifier configurable by an environment variable, so that it can be set to the same identifier as another plugin on the system.
We cannot use other types of settings such as the JSON database, since the plugin identifier is queried before the settings are provided.