Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "release" workflow #26

Open
OpenBagTwo opened this issue Dec 5, 2022 · 2 comments
Open

Create a "release" workflow #26

OpenBagTwo opened this issue Dec 5, 2022 · 2 comments
Labels
dev ops CI/CD

Comments

@OpenBagTwo
Copy link
Owner

This will involve a bit of research.

Creating a release should:

  • build the mod for all supported Minecraft versions
  • build the resource pack generator for all supported platforms
  • add the binaries and jars to the release
  • publish the mod jars to Modrinth
  • publish the mod jars to Curseforge

I'm expecting to do the last three manually for the initial release.

@OpenBagTwo
Copy link
Owner Author

I've created a "lightweight" tag to specify the first release candidate (:crossed_fingers: the code is ready to ship for the initial release) and successfully gotten jgitver to pick it up. Some findings:

  • If a tag isn't "annotated" it will always show the distance after, even if the distance is zero
  • While I got it to show commit hashes and "dirty" tags, I can't get the character before the distance to be "+" instead of "-", but it looks like "+" tags are canonically ignored for precedence anyway, so oh well.
  • The version must be of the form MAJOR.MINOR.PATCH--no leaving off the patch (so the first release will be v0.1.0 and not v0.1 as I was intending)
  • The "v" appears to be optional, at least 🙃
  • v0.1.0-rc1 was kosher--v0.1.0-rc.1 was not

@OpenBagTwo
Copy link
Owner Author

+1 especially if I plan to keep support going all the way back to 1.19[.0]. The v0.1.2 release has a total of six builds, which was a pain in the toucans to upload to Modrinth, and doubly so with Curseforge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev ops CI/CD
Projects
None yet
Development

No branches or pull requests

1 participant