Add manager information from node BMC #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synackd
reviewed
Oct 23, 2024
alexlovelltroy
added
the
not ready for review
|
@davidallendj Looks like this has conflicts that need to be resolved. Adding the "not ready for review" label again until this is fixed. |
Signed-off-by: David Allen <16520934+davidallendj@users.noreply.github.com>
synackd
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Looks good to me.
These changes caused me to revisit #59. We should, in the near future, address how we should name things in an easy but flexible way. It's out of scope for this PR, of course, but it would be quite useful in general.
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional information to the
collectoutput, including theMACAddrandManagersproperties. TheManagersproperty includes information found via the/redfish/v1/Managersendpoint as well as the manager's ethernet interfaces.