fix: ask user to create config file if nonexistent

cmd/config-cluster-set.go

@@ -3,6 +3,7 @@
 package cmd
 
 import (
+	"errors"
 	"os"
 
 	"github.com/OpenCHAMI/ochami/internal/config"
@@ -62,6 +63,17 @@ with a different base URL will change the base URL for the 'foobar' cluster.`,
 			fileToModify = config.UserConfigFile
 		}
 
+		// Ask user to create file if it does not exist
+		if err := AskToCreate(fileToModify); err != nil {
+			if errors.Is(err, UserDeclinedError) {
+				log.Logger.Info().Msgf("user declined creating config file %s, exiting")
+				os.Exit(0)
+			} else {
+				log.Logger.Error().Err(err).Msgf("failed to create %s")
+				os.Exit(1)
+			}
+		}
+
 		// Read in config from file
 		cfg, err := config.ReadConfig(fileToModify)
 		if err != nil {

cmd/config-set.go

@@ -3,6 +3,7 @@
 package cmd
 
 import (
+	"errors"
 	"os"
 	"strings"
 
@@ -54,6 +55,17 @@ This command does not handle cluster configs. For that, use the
 			fileToModify = config.UserConfigFile
 		}
 
+		// Ask user to create file if it does not exist
+		if err := AskToCreate(fileToModify); err != nil {
+			if errors.Is(err, UserDeclinedError) {
+				log.Logger.Info().Msgf("user declined creating config file %s, exiting")
+				os.Exit(0)
+			} else {
+				log.Logger.Error().Err(err).Msgf("failed to create %s")
+				os.Exit(1)
+			}
+		}
+
 		// Refuse to modify config if user tries to modify cluster config
 		if strings.HasPrefix(args[0], "clusters") {
 			log.Logger.Error().Msg("`ochami config set` is meant for modifying general config, use `ochami config cluster set` for modifying cluster config")

cmd/root.go

@@ -4,6 +4,7 @@ package cmd
 
 import (
 	"bufio"
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -24,6 +25,9 @@ const (
 )
 
 var (
+	// Errors
+	UserDeclinedError = fmt.Errorf("user declined")
+
 	configFile string
 	logLevel   string
 	logFormat  string
@@ -112,6 +116,34 @@ func InitLogging() {
 	log.Logger.Debug().Msg("logging has been initialized")
 }
 
+// AskToCreate prompts the user to, if path does not exist, to create a blank
+// file at path. If it exists, nil is returned. If the user declines, a
+// UserDeclinedError is returned. If an error occurs during creation, an error
+// is returned.
+func AskToCreate(path string) error {
+	if path == "" {
+		return fmt.Errorf("path cannot be empty")
+	}
+	if _, err := os.Stat(path); os.IsNotExist(err) {
+		respConfigCreate := loopYesNo(fmt.Sprintf("%s does not exist. Create it?", path))
+		if respConfigCreate {
+			parentDir := filepath.Dir(path)
+			if err := os.MkdirAll(parentDir, 0755); err != nil {
+				return fmt.Errorf("could not create parent dir %s: %w", parentDir, err)
+			}
+			f, err := os.OpenFile(path, os.O_RDONLY|os.O_CREATE, 0644)
+			if err != nil {
+				return fmt.Errorf("creating %s failed: %w", path, err)
+			}
+			f.Close()
+		} else {
+			return UserDeclinedError
+		}
+	}
+
+	return nil
+}
+
 func InitConfig() {
 	// Do not read or write config file if --ignore-config passed
 	if rootCmd.Flag("ignore-config").Changed {
@@ -120,29 +152,13 @@ func InitConfig() {
 
 	if configFile != "" {
 		// Try to create config file with default values if it doesn't exist
-		if _, err := os.Stat(configFile); os.IsNotExist(err) {
-			respConfigCreate := loopYesNo(fmt.Sprintf("Config file %s does not exist. Create it?", configFile))
-			if respConfigCreate {
-				configDir := filepath.Dir(configFile)
-				err := os.MkdirAll(configDir, 0755)
-				if err != nil {
-					fmt.Fprintf(os.Stderr, "%s: could not create config dir %s: %v\n", config.ProgName, configDir, err)
-					os.Exit(1)
-				}
-				f, err := os.OpenFile(configFile, os.O_RDONLY|os.O_CREATE, 0644)
-				if err != nil {
-					fmt.Fprintf(os.Stderr, "%s: creating %s failed: %v\n", config.ProgName, configFile, err)
-					os.Exit(1)
-				}
-				f.Close()
-				err = config.WriteConfig(configFile, config.GlobalConfig)
-				if err != nil {
-					fmt.Fprintf(os.Stderr, "%s: writing %s failed: %v\n", config.ProgName, configFile, err)
-					os.Exit(1)
-				}
-			} else {
-				fmt.Fprintf(os.Stderr, "%s: not creating config file. Exiting...\n", config.ProgName)
+		if err := AskToCreate(configFile); err != nil {
+			if errors.Is(err, UserDeclinedError) {
+				fmt.Fprintf(os.Stderr, "%s: user declined to create file; exiting...\n", config.ProgName)
 				os.Exit(0)
+			} else {
+				fmt.Fprintf(os.Stderr, "%s: failed to create %s: %v\n", config.ProgName, configFile, err)
+				os.Exit(1)
 			}
 		}
 	}