Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom extended themes #9456

Open
wants to merge 15 commits into
base: release/6.5.0
Choose a base branch
from

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Added new Theme objects in backend, along with relevant resolvers and such
  • Modified Settings page to allow admins to create, modify, export, and import custom themes
  • Modified Settings page to allow admins to select default platform theme from a dynamic list
  • Modified User profile page to select their preferred theme from a dynamic list
  • Modified frontend theming to use dynamic themes instead of dark/light themes

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Related to the discussion in #8239, we decided that a better solution would be to allow admins to customize the themes of the platform with greater granularity. This should eventually expand to more fields, such as text color.

@Bonsai8863 Bonsai8863 force-pushed the custom_extended_themes branch from e642007 to 5b9e55e Compare December 30, 2024 16:13
@aHenryJard aHenryJard added the community use to identify PR from community label Dec 31, 2024
@romain-filigran romain-filigran added community use to identify PR from community and removed community use to identify PR from community labels Jan 3, 2025
@Bonsai8863 Bonsai8863 force-pushed the custom_extended_themes branch 3 times, most recently from 5d17496 to 6b5dd2f Compare January 10, 2025 19:04
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 45.02370% with 116 lines in your changes missing coverage. Please review.

Project coverage is 64.48%. Comparing base (845adf3) to head (8bf7ba3).

Files with missing lines Patch % Lines
.../opencti-graphql/src/modules/theme/theme-domain.ts 24.00% 95 Missing ⚠️
...encti-graphql/src/modules/theme/theme-converter.ts 16.00% 21 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9456      +/-   ##
=================================================
- Coverage          64.56%   64.48%   -0.08%     
=================================================
  Files                641      646       +5     
  Lines              61955    62166     +211     
  Branches            6888     6884       -4     
=================================================
+ Hits               39999    40087      +88     
- Misses             21956    22079     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bonsai8863 Bonsai8863 force-pushed the custom_extended_themes branch 3 times, most recently from acd2d49 to 29496b2 Compare January 17, 2025 13:55
@labo-flg labo-flg force-pushed the release/6.5.0 branch 5 times, most recently from 9535c45 to 8574b42 Compare January 17, 2025 16:11
@Bonsai8863 Bonsai8863 force-pushed the custom_extended_themes branch from 29496b2 to 32ca3f1 Compare January 17, 2025 18:42
@Bonsai8863 Bonsai8863 force-pushed the custom_extended_themes branch from 32ca3f1 to 8bf7ba3 Compare January 21, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants