Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not process template arguments when checking for recursive hyperobjects #224

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Do not process template arguments when checking for recursive hyperobjects #224

merged 3 commits into from
Dec 15, 2023

Conversation

VoxSciurorum
Copy link
Contributor

Fixes #223

@VoxSciurorum
Copy link
Contributor Author

With 04d196c, also fixes #222.

@neboat
Copy link
Collaborator

neboat commented Dec 14, 2023

Thanks for working on these fixes. This change looks good to me overall. I verified that it seems to fix both #222 and #223 on my end.

Are there any other changes you're planning for this PR? If not, I'm ready to rebase these changes on top of dev/16.x and merge them in.

@VoxSciurorum
Copy link
Contributor Author

I have no more changes planned for this pull request.

@neboat neboat merged commit aee817f into dev/16.x Dec 15, 2023
2 checks passed
@VoxSciurorum VoxSciurorum deleted the jfc/223 branch December 31, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperobject containing self-referential template causes infinite recursion
2 participants
@VoxSciurorum @neboat