BUILD - Optimize Dockerfile by using alpine as base image #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized Dockerfile by using
alpine:3as base image for build and prod stages.Why is this PR opened as a draft PR?
This is because I talked with @dongresource, and he mentioned that you guys must be sure that changing the datatype of property
TIMEOUTfromsrc/settings.hpptoint64_tworks and doesn't break anything while running the server application.This is a PR mainly intended for allowing you all to know by first hand what is necessary for making the optimizations to Dockerfile.
By the way, the changes made to file
src/settings.hppwere extracted from the branchwin32-x86.