Use FE2CL_..._AROUND, _AROUND_DEL packets #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungcomputerchair
force-pushed
the
around
branch
2 times, most recently
from
65fdeb9 to
73aab0b
Compare
dongresource
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Looks good. I really like how cleanly you implemented this. The main things to fix are the buffer size one-offs and the transportation-around-del gotcha.
I think we should let this one bake on the 104 server for a few days before pushing it to Academy and maybe before merging to the repo as well; just because it's such a core component.
yungcomputerchair
force-pushed
the
around
branch
from
d333bec to
353f90c
Compare
Introduces a generic, fixed-size `Bucket` type in place of the inner vector. This does add size generics but I think it's a very good tradeoff considering how performance-sensitive this codepath is.
yungcomputerchair
force-pushed
the
around
branch
from
353f90c to
486a996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a player's visible chunks change, we send a single enter/exit packet for each entity in the vicinity.
This PR makes it so that we batch these entities in AROUND and AROUND_DEL packets (for enter and exit, respectively).
Since the packet buffer size is fixed, there is a maximum number of entities that we can send per packet. Thus we have to do dynamic batching, helped by a new
Bucketutility class. To minimize the number of packets, I modified the buffer size for 728 and 1013 to match the client's increased buffer size.