Some changes for FreeBSD #1456
Closed
Some changes for FreeBSD #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, do you want to target the 0.10 branch please @RenZ0 ? |
peternewman
reviewed
Jul 31, 2018
common/testing/Makefile.mk
Outdated
| @@ -6,5 +6,6 @@ noinst_LTLIBRARIES += common/testing/libolatesting.la \ | |||
| common_testing_libolatesting_la_SOURCES = \ | |||
| common/testing/MockUDPSocket.cpp \ | |||
| common/testing/TestUtils.cpp | |||
| common_testing_libolatesting_la_CXXFLAGS = $(COMMON_TESTING_PROTOBUF_FLAGS) | |||
There was a problem hiding this comment.
What was the exact message you were getting for this please and I'll see if we can use a more bespoke and appropriate set of flags?
There was a problem hiding this comment.
It's on a big machine and I will start it asap, say in a week or so.
|
This change is also breaking the FreeBSD build: #1226 |
|
Superseded by #1460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is for FreeBSD 10 (old one).
The second one is for FreeBSD 10.4 and 11.2, work in progress.