-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI Java build using correct Autotools env var (closes #1883) #1885
Fix CI Java build using correct Autotools env var (closes #1883) #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to try and fix the codespell typos too?
The distcheck is failing, it looks because this isn't in 0.10, so it might be easiest to just skip testing the Java stuff on 0.10, but the new distcheck stuff can then go into master too, where Java should build, or might need the Java updates from #1882 : |
Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
See #1886.
OK, I modified this to fix the distcheck stuff but disable Java for now. Your following pull can re-enable it. |
@peternewman polite ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
This supersedes #1883 and solves the issue found in #1881.