Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditionals for Protobuf 22+ API changes #1984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cho-m
Copy link

@cho-m cho-m commented Nov 14, 2024

May need to check on some of these like if Abseil's once is equivalent.

Still needs build script fixes/workarounds to actually compile (workarounds specifically for C++17 removed functions assuming Abseil was built with that standard).

On macOS, I was able to build substituting s/-std=gnu++11/-std=gnu++17/g in configure.ac and restoring some removed functions in LLVM libc++:

CXXFLAGS=-D_LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR \
  -D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION \
  -D_LIBCPP_ENABLE_CXX17_REMOVED_BINDERS

============================================================================
Testsuite summary for OLA 0.10.9
============================================================================
# TOTAL: 83
# PASS:  83
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant