fix codechecker errors

Opencast-Moodle · Feb 10, 2022 · d920586 · d920586
1 parent f78be01
commit d920586
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 37 deletions.
diff --git a/classes/admin_setting_configeditabletable.php b/classes/admin_setting_configeditabletable.php
@@ -24,17 +24,14 @@
 
 namespace tool_opencast;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Admin setting class which is used to create an editable table.
  *
  * @package    tool_opencast
  * @copyright  2021 Tamara Gunkel, University of Münster
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class admin_setting_configeditabletable extends \admin_setting
-{
+class admin_setting_configeditabletable extends \admin_setting {
     /** @var string Id of the div tag */
     private $divid;
 

diff --git a/classes/admin_setting_configtextwithvalidation.php b/classes/admin_setting_configtextwithvalidation.php
@@ -27,17 +27,14 @@
 use admin_category;
 use core_plugin_manager;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Admin setting class for OC instances setting.
  *
  * @package    tool_opencast
  * @copyright  2021 Tamara Gunkel, University of Münster
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class admin_setting_configtextwithvalidation extends \admin_setting_configtext
-{
+class admin_setting_configtextwithvalidation extends \admin_setting_configtext {
     /**
      * Validate data before storage
      * @param mixed $data

diff --git a/classes/empty_configuration_exception.php b/classes/empty_configuration_exception.php
@@ -24,18 +24,13 @@
 
 namespace tool_opencast;
 
-
-defined('MOODLE_INTERNAL') || die();
-
-
 /**
  * Exception, which is thrown when the tool settings are empty.
  *
  * @package    tool_opencast
  * @copyright  2021 Tamara Gunkel, University of Münster
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class empty_configuration_exception extends \moodle_exception
-{
+class empty_configuration_exception extends \moodle_exception {
 
 }
diff --git a/classes/local/PolyfillCURLStringFile.php b/classes/local/PolyfillCURLStringFile.php
@@ -31,8 +31,7 @@
  * @copyright  2021 Tamara Gunkel <tamara.gunkel@wi.uni-muenster.de>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class PolyfillCURLStringFile extends \CURLFile
-{
+class PolyfillCURLStringFile extends \CURLFile {
     /** @var string File data */
     private $data;
 

diff --git a/classes/local/api_testable.php b/classes/local/api_testable.php
@@ -24,17 +24,14 @@
 
 namespace tool_opencast\local;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * API used for testing
  *
  * @package    tool_opencast
  * @copyright  2021 Tamara Gunkel <tamara.gunkel@wi.uni-muenster.de>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class api_testable extends api
-{
+class api_testable extends api {
 
     /** @var array array of json responses per endpoint */
     private $jsonresponses;

diff --git a/classes/local/settings_api.php b/classes/local/settings_api.php
@@ -41,8 +41,7 @@
  * @copyright  2021 Tamara Gunkel <tamara.gunkel@wi.uni-muenster.de>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class settings_api extends \curl
-{
+class settings_api extends \curl {
 
     /**
      * Returns the api url of an Opencast instance.

diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php
@@ -20,8 +20,9 @@
  * @copyright  2018 Tobias Reischmann
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
+
 namespace tool_opencast\privacy;
-defined('MOODLE_INTERNAL') || die();
+
 /**
  * Privacy Subsystem for tool_opencast implementing null_provider.
  *
@@ -35,7 +36,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }
diff --git a/classes/seriesmapping.php b/classes/seriesmapping.php
@@ -26,17 +26,14 @@
 
 use tool_opencast\local\settings_api;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Persistable of seriesmapping
  *
  * @package    tool_opencast
  * @copyright  2018 Tobias Reischmann WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class seriesmapping extends \core\persistent
-{
+class seriesmapping extends \core\persistent {
 
     /** Table name for the persistent. */
     const TABLE = 'tool_opencast_series';

diff --git a/db/upgrade.php b/db/upgrade.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Execute opencast upgrade from the given old version
  *

diff --git a/external.php b/external.php
@@ -37,8 +37,7 @@
  * @copyright  2018 Tobias Reischmann <tobias.reischmann@wi.uni-muenster.de>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class tool_opencast_external extends external_api
-{
+class tool_opencast_external extends external_api {
 
     /**
      * Describes the parameters for getting courses for a opencast instructor.

diff --git a/settings.php b/settings.php
@@ -148,7 +148,8 @@
                     get_string('lticonsumerkey_desc', 'tool_opencast'), "");
                 $settings->add($lticonsumerkeysetting);
 
-                $lticonsumersecretsetting = new admin_setting_configpasswordunmask('tool_opencast/lticonsumersecret_' . $instance->id,
+                $lticonsumersecretsetting = new admin_setting_configpasswordunmask(
+                    'tool_opencast/lticonsumersecret_' . $instance->id,
                     get_string('lticonsumersecret', 'tool_opencast'),
                     get_string('lticonsumersecret_desc', 'tool_opencast'), "");
                 $settings->add($lticonsumersecretsetting);

diff --git a/tests/generator/behat_tool_opencast_generator.php b/tests/generator/behat_tool_opencast_generator.php
@@ -23,8 +23,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 
 /**
  * Behat data generator for tool_opencast.

diff --git a/tests/generator/lib.php b/tests/generator/lib.php
@@ -22,8 +22,6 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Tool opencast test data generator class
  *
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,8 +22,6 @@ @@
      * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
      */
-    defined('MOODLE_INTERNAL') || die();
     /**
      * Execute opencast upgrade from the given old version
      *
@@ Expand Down @@