Change date format of ezLog::write to ISO8601 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This format is easier to parse: no language in month string and no white spaces as separator of date components. The use of constant DateTime::ISO8601 (instead of the simpler 'c' parameter) is just to make it more readable.
|
eZDebug also needs this change: see |
DateTime class is include from from php 5.2 |
Opencontent
pushed a commit
that referenced
this pull request
Nov 16, 2024
Update README.md clarified free software license for ibexa oss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This format is easier to parse: no language dependency in month string and no white spaces as separator of date components.
The use of constant DateTime::ISO8601 (instead of the simpler 'c' parameter) is just to make it more readable: the class DateTime is available starting from PHP 5.5 so should be safe use it, but if we have still some environment running on 5.4 we can fallback to 'c' paramenter.
This change could break existing scripts that parse the old format, MERGE WITH CAUTION