Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to karacteristics library for codepoint characteristics #188

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

OptimumCode
Copy link
Owner

No description provided.

@OptimumCode OptimumCode added the enhancement New feature or request label Aug 26, 2024
@OptimumCode OptimumCode changed the title Migrate to karacteristics for codepoint characteristics Migrate to karacteristics library for codepoint characteristics Aug 26, 2024
@OptimumCode OptimumCode enabled auto-merge (squash) August 26, 2024 14:14
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: e792677 Previous: ecd5681 Ratio
macosX64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 3555.1409674620386 us/op 2065.6976921225382 us/op 1.72
macosX64.CommonAvgTimeBench.validateVerbose ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 19396.03594310345 us/op 9124.299141346153 us/op 2.13

This comment was automatically generated by workflow using github-action-benchmark.

CC: @OptimumCode

@OptimumCode OptimumCode merged commit 50ee465 into main Aug 26, 2024
24 checks passed
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (ecd5681) to head (e792677).
Report is 1 commits behind head on main.

Files Patch % Lines
...ema/internal/formats/IdnHostnameFormatValidator.kt 41.17% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   90.68%   90.67%   -0.01%     
==========================================
  Files         130      130              
  Lines        3844     3840       -4     
  Branches     1048     1048              
==========================================
- Hits         3486     3482       -4     
  Misses         65       65              
  Partials      293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode deleted the karacteristics branch September 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant