Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module to wrap kotlin objects for validation #197

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

OptimumCode
Copy link
Owner

Resolves #194

@OptimumCode OptimumCode added the enhancement New feature or request label Sep 7, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (9481407) to head (b86867a).

Files with missing lines Patch % Lines
...timumcode/json/schema/wrappers/objects/Wrappers.kt 91.02% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   90.53%   90.54%   +0.01%     
==========================================
  Files         133      135       +2     
  Lines        3983     4062      +79     
  Branches     1059     1080      +21     
==========================================
+ Hits         3606     3678      +72     
- Misses         82       88       +6     
- Partials      295      296       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: b86867a Previous: 9481407 Ratio
macosArm64.CommonAvgTimeBench.validateBasic ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 1555.2758008896797 us/op 1019.8887628571429 us/op 1.52
macosArm64.CommonAvgTimeBench.validateDetailed ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 3914.697804362416 us/op 2446.4505560679613 us/op 1.60
macosArm64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 1198.658958522727 us/op 763.7483339084771 us/op 1.57

This comment was automatically generated by workflow using github-action-benchmark.

CC: @OptimumCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a separate module for generic objects (e.g. Map, List, primitives)
1 participant