fix message for sig add query params

OrderlyNetwork · Feb 22, 2024 · f8ae23e · f8ae23e
1 parent 614d3cd
commit f8ae23e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/api/py/src/signer.py b/api/py/src/signer.py
@@ -27,8 +27,11 @@ def sign_request(self, req: Request) -> PreparedRequest:
         if req.json is not None:
             json_str = json.dumps(req.json)
 
-        path = urllib.parse.urlparse(req.url).path
-        message = str(timestamp) + req.method + path + json_str
+        url = urllib.parse.urlparse(req.url)
+        message = str(timestamp) + req.method + url.path + json_str
+        if len(url.query) > 0:
+            message += "?" + url.query
+
         orderly_signature = urlsafe_b64encode(
             self._key_pair.sign(message.encode())
         ).decode("utf-8")

diff --git a/api/ts/src/signer.ts b/api/ts/src/signer.ts
@@ -11,7 +11,7 @@ export async function signAndSendRequest(
   const encoder = new TextEncoder();
 
   const url = new URL(input);
-  let message = `${String(timestamp)}${init?.method ?? 'GET'}${url.pathname}`;
+  let message = `${String(timestamp)}${init?.method ?? 'GET'}${url.pathname}${url.search}`;
   if (init?.body) {
     message += init.body;
   }