-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt pyproject.toml standard, fast-forward cookiecutter #135
Conversation
…e hook (uses ruff)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why envrionment.yml became environment-dev.yml?
The reason is that the cookiecutter uses |
Thanks for the info! |
This is good for final review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, flit could be added to environment-dev.yml to not have to install it after
Everything except the docs seems to be working. We're running into resource issues for some reason (are the notebooks too complex?). If you are happy with everything else, we can open another PR to fix that. |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
setup.py
,MANIFEST.in
,requirements*.txt
, and most configs in thesetup.cfg
forpyproject.toml
flake8
checks are now handled viaruff
Does this PR introduce a breaking change?
Yes. We now are using
pyproject.toml
withflit
to build the library. This will entail one or two major changes to a typical development workflow.The main changes worth noting:
$ pip install -e .
should be substituted for$ flit install -s/--symlink
when performing development installations ($ pip install .
works exactly as you'd expect).$ make develop
. This is documented.pyproject.toml
Other information:
https://flit.pypa.io/en/stable/index.html
https://peps.python.org/pep-0518/
https://peps.python.org/pep-0621/
https://www.mypy-lang.org/