Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-3076: Updating Namespace #262

Merged
merged 6 commits into from
Jun 22, 2022
Merged

ROU-3076: Updating Namespace #262

merged 6 commits into from
Jun 22, 2022

Conversation

glundgren93
Copy link
Contributor

This PR updates our API namespace to start having OutSystems.

@glundgren93 glundgren93 requested review from joselrio and gnbm June 21, 2022 13:27
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Jun 21, 2022
gnbm
gnbm previously approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glundgren93 Please , just take a look at the code smells

BenOsodrac
BenOsodrac previously approved these changes Jun 22, 2022
View reviewed changes
@glundgren93 glundgren93 dismissed stale reviews from BenOsodrac and gnbm via 33b3a9e June 22, 2022 08:44
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

No Coverage information No Coverage information
7.3% 7.3% Duplication

@glundgren93
Copy link
Contributor Author

Fixed most code smells. The ones still present are false positives, due to a known issue for sonar with Typescript:
SonarSource/SonarTS#906

@gnbm gnbm requested review from BenOsodrac and gnbm June 22, 2022 12:34
@glundgren93 glundgren93 merged commit 1b92bdf into dev Jun 22, 2022
@glundgren93 glundgren93 deleted the ROU-3076 branch June 22, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnbm gnbm gnbm approved these changes

@joselrio joselrio Awaiting requested review from joselrio

@BenOsodrac BenOsodrac Awaiting requested review from BenOsodrac

Assignees

@joselrio joselrio

@BenOsodrac BenOsodrac

Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glundgren93 @gnbm @BenOsodrac @joselrio