Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-2575 - New Tabs Pattern #143

Closed
wants to merge 72 commits into from
Closed

ROU-2575 - New Tabs Pattern #143

wants to merge 72 commits into from

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Nov 24, 2021 •
edited
Loading

This PR is for the new Tabs Pattern and the TabsHeaderItem and TabsContentItem patterns.

What was done

  • Moved old scss to deprecated file.
  • Created new Tab pattern:
    -- _tabs.scss
    -- Enum.ts
    -- ITabs.ts
    -- Tabs.ts
    -- TabsConfig.ts
  • Created new TabHeaderItem pattern:
    -- ITabHeaderItem.ts
    -- TabHeaderItem.ts
    -- TabHeaderItemConfig.ts
  • Created new TabContentItem pattern:
    -- ITabContentItem.ts
    -- TabContentItem.ts
    -- TabContentItem Config.ts

Screenshots

gif

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@BenOsodrac
depercated old scss
c6b0f32
@BenOsodrac
created initial files structure
cc8fd88
@BenOsodrac
created files for header and content
7d929fe
@BenOsodrac
Tabs basic implementation
29a0e4d
@BenOsodrac
base methods
f2886e7
@BenOsodrac
basic POC functionality
294d0f8
@BenOsodrac
get content and header items
aa8be86
@BenOsodrac
Cleaned up click event
025b62e
@BenOsodrac
toggle active class
8fb02d0
@BenOsodrac
Improved click event
f326699
@BenOsodrac
Added changeProperties and event
300e541
@BenOsodrac
CSS inital styles
5dca166
@BenOsodrac
CSS improvements
c26ab3f
@BenOsodrac
All options on CSS
aa412e3
@BenOsodrac
Implemented onRender and css improvements
771e47f
@BenOsodrac
Improved TabChange method
91d0ea1
@BenOsodrac
Improved Async call
c77cfa4
@BenOsodrac
Added constant for class modifier
db637ab
@BenOsodrac
improved methods architecture
cc083f2
@BenOsodrac
Added hover styles
d5cec0f
@BenOsodrac
Improved typification
8f1d224
@BenOsodrac
Added accessibility attributes
2ea0518
@BenOsodrac
Added kayboard arrow support
99bc326
@BenOsodrac
remove eventListeners onRender
a8c736d
@BenOsodrac
fixed :psedo-element size
2db2d5c
@BenOsodrac
Updated css classes
746fa28
@BenOsodrac
Improved SCSS
9cf7acd
@BenOsodrac
Fixed scroll on header and content
7aae04a
@BenOsodrac
Fixed accessibility focus color
db4bcf5
@BenOsodrac
Fixed border size with accessibility
4143c81
gnbm
gnbm previously approved these changes Nov 25, 2021
View reviewed changes
rugoncalves
rugoncalves requested changes Nov 26, 2021
View reviewed changes
src/scripts/OSUIFramework/GlobalTypes.ts Outdated Show resolved Hide resolved
src/scripts/OSUIFramework/Pattern/Tabs/Tabs.ts Outdated Show resolved Hide resolved
@gnbm gnbm requested a review from rugoncalves November 30, 2021 09:49
gnbm
gnbm previously approved these changes Nov 30, 2021
View reviewed changes
bmarcelino-fe
bmarcelino-fe previously approved these changes Nov 30, 2021
View reviewed changes
rugoncalves
rugoncalves requested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you come back let's review this - have questions! :)

@joselrio joselrio removed their assignment Dec 3, 2021
@BenOsodrac BenOsodrac dismissed stale reviews from bmarcelino-fe and gnbm via 3c14aa5 December 6, 2021 09:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BenOsodrac
Copy link
Contributor Author

Merged code from dev

@BenOsodrac
Copy link
Contributor Author

This PR will be closed and the final Tabs implementation will be fully reviewed on ROU-2622

@BenOsodrac BenOsodrac closed this Dec 6, 2021
@BenOsodrac BenOsodrac deleted the ROU-2575 branch January 4, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarcelino-fe bmarcelino-fe bmarcelino-fe left review comments

@joselrio joselrio Awaiting requested review from joselrio

@OS-simaonunes OS-simaonunes Awaiting requested review from OS-simaonunes

@joanabpereira joanabpereira Awaiting requested review from joanabpereira

@rugoncalves rugoncalves Awaiting requested review from rugoncalves

@gnbm gnbm Awaiting requested review from gnbm

Assignees

@rugoncalves rugoncalves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BenOsodrac @joanabpereira @rugoncalves @bmarcelino-fe @gnbm @joselrio