hardened checks for numeric arguments #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the security sensitive nature of the argon2 program, it should reject any invalid numbers in its arguments. For example, the option `-k 104u576`, which is likely just a typo and should rather be `-k 1048576`, would be taken as 104, which is far less secure than the probably intended 1048576. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
|
@khovratovich Do you know whether this is still maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the security sensitive nature of the argon2 program, it should reject any
invalid numbers in its arguments.
For example, the option
-k 104u576, which is likely just a typo and shouldrather be
-k 1048576, would be taken as 104, which is far less secure than theprobably intended 1048576.
Signed-off-by: Christoph Anton Mitterer mail@christoph.anton.mitterer.name